Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Dependency List
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 829
    • Issues 829
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 60
    • Merge Requests 60
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Issues
  • #1354

Closed
Open
Opened 2 weeks ago by Ben Hayward@benhayward.ben
  • Report abuse
  • New issue
Report abuse New issue

(bug): Banning does not stop user from posting again in public group chat

Summary

Banning from group does not prevent a user from posting

Steps to reproduce

This was tested with @javanick in Help and Support

  1. Have test user account make a post.
  2. Have that account banned from the group.
  3. See that test user can still post.
  4. Refresh, test user can still post.

Platform information

Demonstrated on Chromium / Manjaro, presumably this is low level and universal.

What is the current bug behavior?

User can still post after being banned. On refresh they are shown as not a group member but can still post

What is the expected correct behavior?

User should not be able to post or join the group.

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's very hard to read otherwise.)

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Please solve the reCAPTCHA

We want to be sure it is you, please confirm you are not a robot.

Related issues
0

    Related merge requests
    1
    • [Sprint/GiddyGiraffe] (fix): banning does not stop users from commenting on group activities
      engine !193
    When this merge request is accepted, this issue will be closed automatically.
    • Ben Hayward @benhayward.ben added 0 - Urgent Bug Hunter P - Groups T - Bug labels 2 weeks ago

      added 0 - Urgent Bug Hunter P - Groups T - Bug labels

    • Mark Harding @markeharding changed milestone to %sprint: Giddy Giraffe 2 weeks ago

      changed milestone to %sprint: Giddy Giraffe

    • Mark Harding @markeharding added S - Backlog label 2 weeks ago

      added S - Backlog label

    • Mark Harding @markeharding assigned to @eiennohi 2 weeks ago

      assigned to @eiennohi

    • Mark Harding @markeharding changed weight to 5 2 weeks ago

      changed weight to 5

    • Marcelo Rivera @eiennohi added S - InProgress label and removed S - Backlog label 2 weeks ago

      added S - InProgress label and removed S - Backlog label

    • Marcelo Rivera
      Marcelo Rivera @eiennohi · 2 weeks ago
      Developer

      it's been solved already, in engine@e515f284

    • Marcelo Rivera @eiennohi added S - Review label and removed S - InProgress label 2 weeks ago

      added S - Review label and removed S - InProgress label

    • Mark Harding
      Mark Harding @markeharding · 2 weeks ago
      Owner

      Thats what I thought to, but this was reported only the other day. Can you replicate?

    • Ben Hayward
      Ben Hayward @benhayward.ben · 2 weeks ago
      Developer

      Can confirm. I did this with @javanick after a user who had been banned was still commenting.

      Got him to ban my test account after posting, then could just rejoin the group and post again.

    • Mark Harding @markeharding added S - Backlog label and removed S - Review label 2 weeks ago

      added S - Backlog label and removed S - Review label

    • Marcelo Rivera @eiennohi added S - InProgress label and removed S - Backlog label 2 weeks ago

      added S - InProgress label and removed S - Backlog label

    • Marcelo Rivera
      Marcelo Rivera @eiennohi · 2 weeks ago
      Developer

      I'm guessing maybe @javanick didn't check the "ban permanently" option? I just tested what @benhayward.ben suggested both locally and on production, and it worked as a charm.

    • Marcelo Rivera @eiennohi added S - Review label and removed S - InProgress label 1 week ago

      added S - Review label and removed S - InProgress label

    • Marcelo Rivera @eiennohi mentioned in merge request engine!193 (merged) 1 week ago

      mentioned in merge request engine!193 (merged)

    • Marcelo Rivera
      Marcelo Rivera @eiennohi · 1 week ago
      Developer

      The error was actually when commenting on activities. Just attached an MR with the fix.

    • Mark Harding @markeharding closed via merge request engine!193 (merged) 1 hour ago

      closed via merge request engine!193 (merged)

    • Mark Harding @markeharding mentioned in commit engine@01d29bd9 1 hour ago

      mentioned in commit engine@01d29bd9

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    Marcelo Rivera's avatar Marcelo Rivera @eiennohi
    Assign to
    None
    Epic
    None
    sprint: Giddy Giraffe
    Milestone
    sprint: Giddy Giraffe
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    None
    Due date
    None
    5
    Labels
    0 - Urgent Bug Hunter P - Groups S - Review T - Bug
    Assign labels
    • View project labels
    5
    Weight
    5
    Confidentiality
    Not confidential
    Lock issue
    Unlocked
    4
    4 participants
    user avatar
    Marcelo Rivera
    user avatar
    Mark Harding
    user avatar
    Ben Hayward
    user avatar
    Nicholas Lewis
    Reference: minds/front#1354