(bug): Banning does not stop user from posting again in public group chat
Summary
Banning from group does not prevent a user from posting
Steps to reproduce
This was tested with @javanick in Help and Support
- Have test user account make a post.
- Have that account banned from the group.
- See that test user can still post.
- Refresh, test user can still post.
Platform information
Demonstrated on Chromium / Manjaro, presumably this is low level and universal.
What is the current bug behavior?
User can still post after being banned. On refresh they are shown as not a group member but can still post
What is the expected correct behavior?
User should not be able to post or join the group.
Relevant logs and/or screenshots
(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's very hard to read otherwise.)
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)
added 0 - Urgent Bug Hunter P - Groups T - Bug labels
changed milestone to %sprint: Giddy Giraffe
added S - Backlog label
assigned to @eiennohi
changed weight to 5
added S - InProgress label and removed S - Backlog label
- Developer
it's been solved already, in engine@e515f284
added S - Review label and removed S - InProgress label
- Owner
Thats what I thought to, but this was reported only the other day. Can you replicate?
- Developer
Can confirm. I did this with @javanick after a user who had been banned was still commenting.
Got him to ban my test account after posting, then could just rejoin the group and post again.
added S - Backlog label and removed S - Review label
added S - InProgress label and removed S - Backlog label
- Developer
I'm guessing maybe @javanick didn't check the "ban permanently" option? I just tested what @benhayward.ben suggested both locally and on production, and it worked as a charm.
added S - Review label and removed S - InProgress label
mentioned in merge request engine!193 (merged)
- Developer
The error was actually when commenting on activities. Just attached an MR with the fix.
closed via merge request engine!193 (merged)
mentioned in commit engine@01d29bd9