Skip to content

Minds Frontend
Minds Frontend
Open
Opened by Marcelo Rivera@eiennohi
Report abuse

[Sprint/GiddyGiraffe] (fix): gathering button should stop pulsating after the gathering ends

closes #1412

Request to merge eiennohi:sprint/GiddyGiraffe.fix.gathering-button-continues-pulsating-indefinitely into master
Open in Web IDE
Pipeline #66988083 passed for 77c2bd05 on eiennohi:sprint/GiddyGiraffe.fix.gathering-button-continues-pulsating-indefinitely
    Requires 2 more approvals from Devs.
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request

    Allows commits from members who can merge to the target branch

    Closes #1412

    Deletes source branch

    0/1 discussion resolved
    • Marcelo Rivera @eiennohi added 1 commit

      added 1 commit

      • 77c2bd05 - (fix): gathering button should stop pulsating after the gathering ends

      Compare with previous version

    • Emiliano Balbuena @edgebal approved this merge request

      approved this merge request

    • Emiliano Balbuena @edgebal unapproved this merge request

      unapproved this merge request

    • Emiliano Balbuena
      Emiliano Balbuena @edgebal started a discussion on the diff
      src/app/modules/groups/profile/profile.ts
      181 181 this.updateMarkersSubscription.unsubscribe();
      182 182
      183 183 this.updateMarkersSubscription = this.updateMarkers.getByEntityGuid(this.guid).subscribe((marker => {
      184 // this.updateMarkersSubscription = this.updateMarkers.markers.subscribe(markers => {
      184 185 if (!marker)
      185 186 return;
      186 187
      187 this.group.hasGathering = marker && marker.entity_guid == this.group.guid
      188 && marker.marker == 'gathering-heartbeat'
      189 && marker.updated_timestamp > (Date.now() / 1000) - 60;
      188 this.group.hasGathering$ = interval(1000).pipe(
      189 throttle(() => interval(2000)), //only allow once per 2 seconds
      190 startWith(0),
      191 map(() => [marker].filter(marker => marker.entity_guid == this.group.guid
      Please register or sign in to reply
    • Marcelo Rivera
      Marcelo Rivera @eiennohi ·
      Developer

      I'm not well versed in rxjs, and I couldn't find a good solution to this. On the other hand, we do need a solution similar to this one, as the frontend stops sending messages via sockets when the gathering stops.

    Please register or sign in to reply