Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 146
    • Issues 146
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 38
    • Merge Requests 38
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Issues
  • #110

Closed
Open
Opened 4 months ago by Bill Ottman@ottman:dragon_face:
  • Report abuse
  • New issue
Report abuse New issue

(bug): Banners not saving down, ditch carousels

Summary

(Summarize the bug encountered concisely)

Banners are not saving down on mobile or web for channels repeatedly.

Steps to reproduce

(How one can reproduce the issue - this is very important)

Upload a new banner, especially larger files

Platform information

(Browser, device, system stats, screen size)

chrome, firefox, android

What is the current bug behavior?

(What actually happens)

What is the expected correct behavior?

(What you should see instead)

saves down no issues

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's very hard to read otherwise.)

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Please solve the reCAPTCHA

We want to be sure it is you, please confirm you are not a robot.

Related issues
0

    Related merge requests
    1
    • [Sprint/Ohms] (feat): loading indicator and error message for banners
      front !112
    • Bill Ottman :dragon_face: @ottman added 2 - Normal P - Channels S - Backlog T - Bug labels 4 months ago

      added 2 - Normal P - Channels S - Backlog T - Bug labels

    • Bill Ottman :dragon_face: @ottman added 0 - Urgent label and removed 2 - Normal label 4 months ago

      added 0 - Urgent label and removed 2 - Normal label

    • Mark Harding
      Mark Harding @markeharding · 4 months ago
      Owner

      Can you please test with another channel eliminate platform/device issues?

    • Mark Harding
      Mark Harding @markeharding · 4 months ago
      Owner

      Also if you open up your XHR log and look for 'carouse' field. Please provide the output thereScreen_Shot_2019-01-18_at_17.39.40. Try waiting 30-60 seconds also before refreshing.

    • Mark Harding
      Mark Harding @markeharding · 4 months ago
      Owner

      Please also attach the banners you are trying to upload.

    • Mark Harding
      Mark Harding @markeharding · 4 months ago
      Owner

      Banner change too 1.2mins (too slow), especially as no visual output is given. Screen_Shot_2019-01-18_at_17.43.01

    • Bill Ottman
      Bill Ottman :dragon_face: @ottman · 4 months ago
      Owner

      Neither of these would save down. I tried another photo and it saved.

      IMG_9139Screenshot_from_2019-01-18_12-32-45

    • Marcelo Rivera
      Marcelo Rivera @eiennohi · 4 months ago
      Developer

      About those two images Bill posted, the PHP process seems to be running out of memory. I bet it has to do with the thumbnail generation part. We can either raise the maximum memory allowed for PHP processes or further test https://github.com/Minds/engine-internal/pull/598

    • Mark Harding
      Mark Harding @markeharding · 4 months ago
      Owner

      Lets put in upload progress dialogue and alert if errors.

    • Mark Harding @markeharding changed milestone to %sprint: Ohms 4 months ago

      changed milestone to %sprint: Ohms

    • Mark Harding @markeharding changed weight to 10 4 months ago

      changed weight to 10

    • Mark Harding @markeharding assigned to @eiennohi 4 months ago

      assigned to @eiennohi

    • Marcelo Rivera @eiennohi added S - InProgress label and removed S - Backlog label 4 months ago

      added S - InProgress label and removed S - Backlog label

    • Marcelo Rivera @eiennohi mentioned in merge request front!112 4 months ago

      mentioned in merge request front!112

    • Marcelo Rivera @eiennohi added S - Review label and removed S - InProgress label 4 months ago

      added S - Review label and removed S - InProgress label

    • Mark Harding @markeharding removed milestone 3 months ago

      removed milestone

    • Mark Harding @markeharding closed 1 minute ago

      closed

    • Mark Harding
      Mark Harding @markeharding · just now
      Owner

      Imagick should solve

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    Marcelo Rivera's avatar Marcelo Rivera @eiennohi
    Assign to
    None
    Epic
    None
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    None
    Due date
    None
    4
    Labels
    0 - Urgent P - Channels S - Review T - Bug
    Assign labels
    • View project labels
    10
    Weight
    10
    Confidentiality
    Not confidential
    Lock issue
    Unlocked
    3
    3 participants
    user avatar
    Marcelo Rivera
    user avatar
    Mark Harding
    user avatar
    Bill Ottman
    Reference: minds/engine#110