Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 822
    • Issues 822
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 59
    • Merge Requests 59
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !172

Closed
Opened 3 months ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/Subscribers] (fix): cannot delete replies to comments on your own posts

closes engine#224 (closed)

Edited 3 months ago by Marcelo Rivera

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/eiennohi/front.git sprint/Subscribers.fix.cannot-delete-replies-to-comments-on-your-own-posts
git checkout -b eiennohi/front-sprint/Subscribers.fix.cannot-delete-replies-to-comments-on-your-own-posts FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff eiennohi/front-sprint/Subscribers.fix.cannot-delete-replies-to-comments-on-your-own-posts

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge eiennohi:sprint/Subscribers.fix.cannot-delete-replies-to-comments-on-your-own-posts into master
  • Email patches
  • Plain diff
Pipeline #52373686 passed for eba14243 on eiennohi:sprint/Subscribers.fix.cannot-delete-replies-to-comments-on-your-own-posts
    Requires 2 more approvals.

    Closed by Mark Harding 55 minutes ago

    The changes were not merged into master

    Allows commits from members who can merge to the target branch

    Did not close engine#224 (closed)

    Deletes source branch

    • Discussion 1
    • Commits 2
    • Pipelines 3
    • Changes 4
    • Loading...
    • Marcelo Rivera @eiennohi changed the description 3 months ago

      changed the description

    • Marcelo Rivera @eiennohi added 2 commits 3 months ago

      added 2 commits

      • 60d1134c - 1 commit from branch minds:master
      • bde168c2 - (fix): cannot delete replies to comments on your own posts

      Compare with previous version

    • Marcelo Rivera @eiennohi added 107 commits 3 months ago

      added 107 commits

      • bde168c2...be8a345a - 106 commits from branch minds:master
      • eba14243 - Merge remote-tracking branch 'upstream/master' into...

      Compare with previous version

    • Mark Harding
      Mark Harding @markeharding · 55 minutes ago
      Owner

      replaced with f6915ada

    • Mark Harding @markeharding closed 55 minutes ago

      closed

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    2
    2 participants
    user avatar
    Mark Harding
    user avatar
    Marcelo Rivera
    Reference: minds/front!172