Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 828
    • Issues 828
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 63
    • Merge Requests 63
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !348

Open
Opened 1 week ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/GiddyGiraffe](bug): Removed height from login component to stop overflow on TOS button

Closes minds#450

image

The above button was previously cut off

We could possibly get rid of the margin too, but I decided to leave it in to be safe. Let me know.

Edited 1 week ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git fix-slight-tos-cutoff-onboarding
git checkout -b benhayward.ben/front-fix-slight-tos-cutoff-onboarding FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-fix-slight-tos-cutoff-onboarding

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:fix-slight-tos-cutoff-onboarding into master
The source branch is 45 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #65732137 passed for bb85f84f on benhayward.ben:fix-slight-tos-cutoff-onboarding
    Merge request approved. Approved by
    Marcelo Rivera
    Marcelo Rivera
    Brian Hatchet
    Brian Hatchet
    Martin Santangelo
    Martin Santangelo
    Emiliano Balbuena
    Emiliano Balbuena
    Mark Harding
    Mark Harding
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request

    Allows commits from members who can merge to the target branch

    Closes minds#450

    Deletes source branch

    • Discussion 1
    • Commits 1
    • Pipelines 1
    • Changes 1
    0/1 discussion resolved
    • Loading...
    • Ben Hayward @benhayward.ben changed the description 1 week ago

      changed the description

    • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 1 week ago

      approved this merge request

    • Marcelo Rivera @eiennohi approved this merge request 5 days ago

      approved this merge request

    • Mark Harding
      Mark Harding @markeharding started a discussion on the diff 4 minutes ago
      src/app/modules/auth/login.component.scss
      12 12 display: flex;
      13 13 max-width: 990px;
      14 14 flex-direction: row;
      15 height: 100%;
      • Mark Harding
        Mark Harding @markeharding · 4 minutes ago
        Owner

        I think this should be min-height: 100% or else desktop has a great big grey bar

      Please register or sign in to reply
    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Martin Santangelo
    user avatar
    Emiliano Balbuena
    user avatar
    Mark Harding
    user avatar
    Marcelo Rivera
    user avatar
    Brian Hatchet
    user avatar
    Ben Hayward
    Reference: minds/front!348