(cache)(fix): don't send offset and finish if they weren't explicitly provided (!358) · Merge Requests · Minds / Minds Frontend · GitLab

(fix): don't send offset and finish if they weren't explicitly provided

closes #380 (closed)

Edited 4 hours ago by Marcelo Rivera

Request to merge eiennohi:sprint/GiddyGiraffe.fix.duplicated-messages-issue-in-messenger into master

0/1 discussion resolved

Marcelo Rivera @eiennohi mentioned in merge request engine!211 (closed) 20 hours ago

mentioned in merge request engine!211 (closed)

Mark Harding @markeharding started a discussion on an old version of the diff 9 hours ago

Last updated by Marcelo Rivera 4 hours ago

src/app/modules/messenger/conversation/conversation.component.ts

169	167	fromSelf = true;
170	168	}
171	169
172	170	this.load({ finish: message.guid });
Mark Harding @markeharding · 9 hours ago Owner @eiennohi why not just pass through `limit: 1` here rather than changing the backend? Marcelo Rivera @eiennohi changed this line in version 2 of the diff 4 hours ago changed this line in version 2 of the diff Marcelo Rivera @eiennohi · 4 hours ago Developer done. closing the other MR Please register or sign in to reply

Marcelo Rivera @eiennohi added 1 commit 4 hours ago
added 1 commit

302dc6c0 - (fix): send limit: 1 when listening from socket

Compare with previous version
Marcelo Rivera @eiennohi changed the description 4 hours ago

changed the description
Mark Harding @markeharding approved this merge request 4 hours ago

approved this merge request
Emiliano Balbuena @edgebal approved this merge request 3 hours ago

approved this merge request
Mark Harding @markeharding merged 3 hours ago

merged
Mark Harding @markeharding mentioned in commit 291c4e63 3 hours ago

mentioned in commit 291c4e63
You're only seeing other activity in the feed. To add a comment, switch to one of the following options.

Please register or sign in to reply