Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 835
    • Issues 835
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 62
    • Merge Requests 62
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Issues
  • #380

Closed
Open
Opened 4 months ago by Jake Passi@JakePassi
  • Report abuse
  • New issue
Report abuse New issue

(bug): Every time a new message is received in messenger in real-time it copies the previous 11 or so.

Summary

This bug is driving me nuts. Please fix it asap. Every time a new message is received in messenger in real-time it copies the previous 11 or so. It is copying both sent and received messages. I think it's treating it as if it's the first time the chat window has been opened, simply loading the previous 11 sent/received messages but not realizing that those previous messages have already loaded. It should only load the new message(s).

Steps to reproduce

  1. Log in to your primary account in Chrome.
  2. Log in to your secondary account in Firefox.
  3. Send 13 numbered messages (test1, test2, test3, etc.) from your secondary account to your primary account.
  4. Send a message from your primary account to your secondary account without closing the chat window.
  5. Send another message from your secondary account to your primary account without closing the chat window.

Platform information

Chrome/Win10 and Firefox/Win10

What is the current bug behavior?

Every time a new message is received in messenger in real-time it copies the previous 11 or so.

What is the expected correct behavior?

It should only load the new message(s).

Relevant logs and/or screenshots

(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's very hard to read otherwise.)

Possible fixes

(If you can, link to the line of code that might be responsible for the problem)

Please solve the reCAPTCHA

We want to be sure it is you, please confirm you are not a robot.

Related issues
0

    Related merge requests
    3
    • [Sprint/Zero](bug): Duplicate message bug fix
      !243
    • (fix): don't send offset and finish if they weren't explicitly provided
      !358
    • [Sprint/GiddyGiraffe] (fix): if finish is provided, limit to 1
      engine !211
    When these merge requests are accepted, this issue will be closed automatically.
    • Jake Passi @JakePassi added 0 - Urgent P - Messenger T - Bug labels 4 months ago

      added 0 - Urgent P - Messenger T - Bug labels

    • Mark Harding @markeharding added 1 - High label and removed 0 - Urgent label 4 months ago

      added 1 - High label and removed 0 - Urgent label

    • Mark Harding @markeharding changed milestone to %sprint: Remind 4 months ago

      changed milestone to %sprint: Remind

    • Mark Harding @markeharding assigned to @benhayward.ben 4 months ago

      assigned to @benhayward.ben

    • Mark Harding @markeharding added S - Backlog label 3 months ago

      added S - Backlog label

    • Ben Hayward @benhayward.ben changed milestone to %sprint: Subscribers 3 months ago

      changed milestone to %sprint: Subscribers

    • Ben Hayward @benhayward.ben changed weight to 5 3 months ago

      changed weight to 5

    • Mark Harding @markeharding changed milestone to %sprint: Tags 3 months ago

      changed milestone to %sprint: Tags

    • Ben Hayward @benhayward.ben added S - InProgress label and removed S - Backlog label 3 months ago

      added S - InProgress label and removed S - Backlog label

    • Ben Hayward @benhayward.ben added S - Follow Up label and removed S - Backlog label 3 months ago

      added S - Follow Up label and removed S - Backlog label

    • Ben Hayward @benhayward.ben added S - Backlog label and removed S - Follow Up label 3 months ago

      added S - Backlog label and removed S - Follow Up label

    • Ben Hayward @benhayward.ben added S - InProgress label and removed S - Backlog label 3 months ago

      added S - InProgress label and removed S - Backlog label

    • Ben Hayward @benhayward.ben added S - Backlog label and removed S - InProgress label 3 months ago

      added S - Backlog label and removed S - InProgress label

    • Ben Hayward @benhayward.ben added S - Follow Up label and removed S - Backlog label 3 months ago

      added S - Follow Up label and removed S - Backlog label

    • Ben Hayward @benhayward.ben changed milestone to %sprint: X 2 months ago

      changed milestone to %sprint: X

    • Ben Hayward @benhayward.ben added S - Backlog label and removed S - Follow Up label 2 months ago

      added S - Backlog label and removed S - Follow Up label

    • Ben Hayward @benhayward.ben added S - Review label and removed S - Backlog label 2 months ago

      added S - Review label and removed S - Backlog label

    • Ben Hayward @benhayward.ben added S - InProgress label and removed S - Review label 2 months ago

      added S - InProgress label and removed S - Review label

    • Ben Hayward @benhayward.ben added S - Backlog label and removed S - InProgress label 2 months ago

      added S - Backlog label and removed S - InProgress label

    • Ben Hayward
      Ben Hayward @benhayward.ben · 2 months ago
      Developer

      Identified an issue with Sockets that is stopping live messaging when running the site locally, which has halted progress on this bug until it can be replicated locally. @edgebal has confirmed that he also has the same issue, and found the cause to be Redis not keeping a record of the session id.

      Edited by Ben Hayward 2 months ago
    • Ben Hayward @benhayward.ben added S - Follow Up label and removed S - Backlog label 2 months ago

      added S - Follow Up label and removed S - Backlog label

    • Ben Hayward @benhayward.ben changed milestone to %sprint: Zero 2 months ago

      changed milestone to %sprint: Zero

    • Ben Hayward @benhayward.ben added S - InProgress label and removed S - Follow Up label 2 months ago

      added S - InProgress label and removed S - Follow Up label

    • Ben Hayward
      Ben Hayward @benhayward.ben · 2 months ago
      Developer

      The above was kindly fixed.

      Investigating this shows me that the issue seems to be likely caused by sending messages too quickly.

      I need to double check this on a fresh head but it appears:

      • Bob sends Alice messages reading "1" and "2" in rapid succession.
      • Alice's chat receives "1" first and begins to load it into the chat.
      • Alice's chat receives a messages object containing the text "1" and "2" and begins to load it.
      • Alice's chat adds the first 'messages' object (containing the singular "1").
      • Alice's chat adds the second set of messages (containing "1" and "2").

      Thus alices chat will read

      1 | < first time messages come in

      1 | < second time messages come in

      2 | < second time messages come in

      Edited by Ben Hayward 2 months ago
    • Ben Hayward @benhayward.ben added S - Review label and removed S - InProgress label 2 months ago

      added S - Review label and removed S - InProgress label

    • Ben Hayward @benhayward.ben mentioned in merge request !243 2 months ago

      mentioned in merge request !243

    • Ben Hayward @benhayward.ben mentioned in issue #385 (closed) 2 months ago

      mentioned in issue #385 (closed)

    • Mark Harding @markeharding changed milestone to %sprint: Dapper Dingo 1 month ago

      changed milestone to %sprint: Dapper Dingo

    • Mark Harding @markeharding added S - Backlog label and removed S - Review label 1 month ago

      added S - Backlog label and removed S - Review label

    • Ben Hayward
      Ben Hayward @benhayward.ben · 1 month ago
      Developer

      Have tried a couple of times to get to the bottom of this and propose an actual fix. I suspect the issue may be in the sockets code which I'm not well acquainted with. Going to un-assign myself, if nobody else wants to pick it up, I'll re-assign but don't feel it'd be very time effective for me.

    • Ben Hayward @benhayward.ben unassigned @benhayward.ben 1 month ago

      unassigned @benhayward.ben

    • Ben Hayward @benhayward.ben changed milestone to %sprint: Elevated Eagle 1 month ago

      changed milestone to %sprint: Elevated Eagle

    • Ben Hayward @benhayward.ben removed S - Backlog label 1 month ago

      removed S - Backlog label

    • Ben Hayward @benhayward.ben added Bug Hunter label 3 weeks ago

      added Bug Hunter label

    • Mark Harding @markeharding assigned to @eiennohi 1 week ago

      assigned to @eiennohi

    • Mark Harding @markeharding added S - Backlog label 1 week ago

      added S - Backlog label

    • Mark Harding @markeharding changed milestone to %sprint: Giddy Giraffe 1 week ago

      changed milestone to %sprint: Giddy Giraffe

    • Marcelo Rivera @eiennohi added S - InProgress label 1 week ago

      added S - InProgress label

    • Marcelo Rivera @eiennohi added S - Follow Up label and removed S - InProgress label 6 days ago

      added S - Follow Up label and removed S - InProgress label

    • Marcelo Rivera @eiennohi added S - Review label and removed S - Follow Up label 20 hours ago

      added S - Review label and removed S - Follow Up label

    • Marcelo Rivera @eiennohi mentioned in merge request engine!211 (closed) 20 hours ago

      mentioned in merge request engine!211 (closed)

    • Marcelo Rivera @eiennohi mentioned in merge request !358 (merged) 20 hours ago

      mentioned in merge request !358 (merged)

    • Marcelo Rivera @eiennohi changed weight to 7 3 hours ago

      changed weight to 7

    • Mark Harding @markeharding closed via merge request !358 (merged) 3 hours ago

      closed via merge request !358 (merged)

    • Mark Harding @markeharding mentioned in commit 291c4e63 3 hours ago

      mentioned in commit 291c4e63

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    Marcelo Rivera's avatar Marcelo Rivera @eiennohi
    Assign to
    None
    Epic
    None
    sprint: Giddy Giraffe
    Milestone
    sprint: Giddy Giraffe
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    None
    Due date
    None
    6
    Labels
    1 - High Bug Hunter P - Messenger S - Backlog S - Review T - Bug
    Assign labels
    • View project labels
    7
    Weight
    7
    Confidentiality
    Not confidential
    Lock issue
    Unlocked
    5
    5 participants
    user avatar
    Marcelo Rivera
    user avatar
    Mark Harding
    user avatar
    Ben Hayward
    user avatar
    Jake Passi
    user avatar
    Emiliano Balbuena
    Reference: minds/front#380