Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Mobile
Minds Mobile
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 186
    • Issues 186
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 6
    • Merge Requests 6
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • Minds
  • Minds MobileMinds Mobile
  • Merge Requests
  • !228

Open
Opened 2 hours ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/GiddyGiraffe](bug): Removed linking and conditionally shown globe icon in blogs

Conflict with !224 Will resolve once that is merged in, please look at that first.

My logic here was that the globe button is probably just meant to be for license due to its location (next to the license text), and as such, it shouldn't be directing anywhere, or shown if there is no license set.

Edited 1 hour ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/mobile-native.git globe-icon-fix-blog-post-774
git checkout -b benhayward.ben/mobile-native-globe-icon-fix-blog-post-774 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/mobile-native-globe-icon-fix-blog-post-774

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:globe-icon-fix-blog-post-774 into master
The source branch is 20 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #66785467 (#215) passed for a5a20b2e on benhayward.ben:globe-icon-fix-blog-post-774
    No approval required
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request

    Allows commits from members who can merge to the target branch

    Deletes source branch

    • Discussion 0
    • Commits 2
    • Pipelines 2
    • Changes 2
    • Loading...
    • Ben Hayward @benhayward.ben added 1 commit 1 hour ago

      added 1 commit

      • a5a20b2e - Added snapshot

      Compare with previous version

    • Ben Hayward @benhayward.ben changed the description 1 hour ago

      changed the description

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    1
    1 participant
    user avatar
    Ben Hayward
    Reference: minds/mobile-native!228