Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 158
    • Issues 158
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 40
    • Merge Requests 40
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !192

Open
Opened 1 week ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/GiddyGiraffe] (fix): don't show suggestions if near subscriptions ratelimit threshold

closes #267

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/eiennohi/engine.git sprint/GiddyGiraffe.fix.dont-suggest-users-over-ratelimit-threshold
git checkout -b eiennohi/engine-sprint/GiddyGiraffe.fix.dont-suggest-users-over-ratelimit-threshold FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff eiennohi/engine-sprint/GiddyGiraffe.fix.dont-suggest-users-over-ratelimit-threshold

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge eiennohi:sprint/GiddyGiraffe.fix.dont-suggest-users-over-ratelimit-threshold into master
The source branch is 31 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #66752941 (#985) failed for a630a65e on eiennohi:sprint/GiddyGiraffe.fix.dont-suggest-users-over-ratelimit-threshold
      Requires 2 more approvals from Devs.
      Martin Santangelo
      Martin Santangelo
      Emiliano Balbuena
      Emiliano Balbuena
      Rami Albatal
      Rami Albatal
      Brian Hatchet
      Brian Hatchet
      Mark Harding
      Mark Harding
      Ready to be merged automatically. Ask someone with write access to this repository to merge this request

      Allows commits from members who can merge to the target branch

      Closes #267

      Deletes source branch

      • Discussion 3
      • Commits 3
      • Pipelines 3
      • Changes 5
      0/1 discussion resolved
      • Loading...
      • Mark Harding
        Mark Harding @markeharding · 1 week ago
        Owner

        Can this be moved to Manager with spec tests for safety?

      • Marcelo Rivera @eiennohi added 2 commits 1 week ago

        added 2 commits

        • 99204fa7 - (fix): don't show suggestions if near subscriptions ratelimit threshold
        • 30c527c7 - (feat): spec tests

        Compare with previous version

      • Mark Harding
        Mark Harding @markeharding started a discussion on an old version of the diff 5 hours ago
        Last updated by Marcelo Rivera 1 hour ago
        Core/Suggestions/Delegates/CheckRateLimit.php
        24 $this->cacher = $cacher ?: Di::_()->get('Cache');
        25 $this->maps = $maps ?: Maps::$maps;
        26 }
        27
        28 /**
        29 * @param int|string $userGuid
        30 */
        31 public function setUserGuid($userGuid)
        32 {
        33 $this->userGuid = $userGuid;
        34 }
        35
        36 /**
        37 * @return bool false if about to get rate limited
        38 */
        39 public function check()
        • Mark Harding
          Mark Harding @markeharding · 5 hours ago
          Owner

          Ideally delegates should be stateless, so if we could pass $userGuid through as a variable vs class context

        • Marcelo Rivera @eiennohi changed this line in version 3 of the diff 2 hours ago

          changed this line in version 3 of the diff

        • Marcelo Rivera
          Marcelo Rivera @eiennohi · 1 hour ago
          Developer

          fixed

        Please register or sign in to reply
      • Marcelo Rivera @eiennohi added 1 commit 2 hours ago

        added 1 commit

        • a630a65e - (fix): delegates should be stateless

        Compare with previous version

      • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
      Please register or sign in to reply
      Assignee
      None
      Assign to
      None
      Milestone
      None
      Assign milestone
      None
      Time tracking
      No estimate or time spent
      0
      Labels
      None
      Assign labels
      • View project labels
      Lock merge request
      Unlocked
      7
      7 participants
      user avatar
      Martin Santangelo
      user avatar
      Emiliano Balbuena
      user avatar
      Rami Albatal
      user avatar
      Brian Hatchet
      user avatar
      Mark Harding
      user avatar
      Ben Hayward
      user avatar
      Marcelo Rivera
      Reference: minds/engine!192