Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 157
    • Issues 157
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 40
    • Merge Requests 40
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !207

Open
Opened 3 days ago by Emiliano Balbuena@edgebal
  • Report abuse
Report abuse

WIP: (feat): Boost Campaigns module

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/edgebal/engine.git goal/campaigns-1
git checkout -b edgebal/engine-goal/campaigns-1 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff edgebal/engine-goal/campaigns-1

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge edgebal:goal/campaigns-1 into master
The source branch is 10 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #66742480 (#563) passed for 91f941b7 on edgebal:goal/campaigns-1
      Requires 2 more approvals from Devs.
      Martin Santangelo
      Martin Santangelo
      Marcelo Rivera
      Marcelo Rivera
      Rami Albatal
      Rami Albatal
      Brian Hatchet
      Brian Hatchet
      Mark Harding
      Mark Harding
      This is a Work in Progress

      Allows commits from members who can merge to the target branch

      Deletes source branch

      You can merge this merge request manually using the
      • Discussion 6
      • Commits 4
      • Pipelines 4
      • Changes 12
      3/4 discussions resolved
      • Loading...
      • Emiliano Balbuena @edgebal added 1 commit 9 hours ago

        added 1 commit

        • ad87348f - (proto): Create campaign normalization and validation

        Compare with previous version

      • Mark Harding
        Mark Harding @markeharding started a discussion on an old version of the diff 3 hours ago
        Resolved by Emiliano Balbuena 2 hours ago
      • Mark Harding
        Mark Harding @markeharding started a discussion on an old version of the diff 3 hours ago
        Resolved by Emiliano Balbuena 2 hours ago
      • Mark Harding
        Mark Harding @markeharding started a discussion on an old version of the diff 3 hours ago
        Last updated by Emiliano Balbuena 2 hours ago
        Core/Boost/Campaigns/Manager.php
        118 throw new CampaignException('Campaign should have a budget');
        119 }
        120
        121 // TODO: Validate offchain balance, or set as pending for onchain
        122
        123 // Generate URN
        124
        125 $guid = $this->guid->build();
        126 $urn = "urn:campaign:{$guid}";
        127
        128 $campaign
        129 ->setUrn($urn);
        130
        131 // Normalize and validate entity URNs
        132
        133 $entityUrns = array_values(array_unique(array_filter(Text::buildArray($campaign->getEntityUrns()))));
        • Mark Harding
          Mark Harding @markeharding · 3 hours ago
          Owner

          :head_bandage: not sure what we can do here to avoid function overload

        • Emiliano Balbuena @edgebal changed this line in version 3 of the diff 2 hours ago

          changed this line in version 3 of the diff

        • Emiliano Balbuena
          Emiliano Balbuena @edgebal · 2 hours ago
          Developer

          Awful, eh? I was thinking on creating a Collection class as a wrapper to arrays. Pretty much like Response but without any paging tokens, etc references.

        Please register or sign in to reply
      • Mark Harding
        Mark Harding @markeharding started a discussion on an old version of the diff 3 hours ago
        Resolved by Emiliano Balbuena 2 hours ago
      • Emiliano Balbuena @edgebal added 1 commit 2 hours ago

        added 1 commit

        • 75ba2677 - (proto): Campaign create/update delegates

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 hours ago

        added 1 commit

        • 91f941b7 - (chore): Use manager for listing

        Compare with previous version

      • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
      Please register or sign in to reply
      Assignee
      Emiliano Balbuena's avatar Emiliano Balbuena @edgebal
      Assign to
      None
      Milestone
      None
      Assign milestone
      None
      Time tracking
      No estimate or time spent
      0
      Labels
      None
      Assign labels
      • View project labels
      Lock merge request
      Unlocked
      7
      7 participants
      user avatar
      Martin Santangelo
      user avatar
      Marcelo Rivera
      user avatar
      Rami Albatal
      user avatar
      Brian Hatchet
      user avatar
      Mark Harding
      user avatar
      Ben Hayward
      user avatar
      Emiliano Balbuena
      Reference: minds/engine!207