Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 835
    • Issues 835
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 62
    • Merge Requests 62
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !358

Merged
Opened 17 hours ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

(fix): don't send offset and finish if they weren't explicitly provided

closes #380 (closed)

Edited 2 hours ago by Marcelo Rivera
Request to merge eiennohi:sprint/GiddyGiraffe.fix.duplicated-messages-issue-in-messenger into master
  • Email patches
  • Plain diff
Pipeline #66745274 (#1940) passed for 302dc6c0 on eiennohi:sprint/GiddyGiraffe.fix.duplicated-messages-issue-in-messenger
    Merge request approved. Approved by
    Emiliano Balbuena
    Emiliano Balbuena
    Mark Harding
    Mark Harding
    Martin Santangelo
    Martin Santangelo
    Brian Hatchet
    Brian Hatchet
    Ben Hayward
    Ben Hayward

    Merged by Mark Harding 45 minutes ago

    The changes were merged into master with 291c4e63

    The source branch has been deleted

    Allows commits from members who can merge to the target branch

    Closed #380 (closed)

    Pipeline #66767873 (#504) passed for 291c4e63 on master
          • Discussion 2
          • Commits 2
          • Pipelines 2
          • Changes 1
          0/1 discussion resolved
          • Loading...
          • Marcelo Rivera @eiennohi mentioned in merge request engine!211 (closed) 17 hours ago

            mentioned in merge request engine!211 (closed)

          • Mark Harding
            Mark Harding @markeharding started a discussion on an old version of the diff 6 hours ago
            Last updated by Marcelo Rivera 2 hours ago
            src/app/modules/messenger/conversation/conversation.component.ts
            169 167 fromSelf = true;
            170 168 }
            171 169
            172 170 this.load({ finish: message.guid });
            • Mark Harding
              Mark Harding @markeharding · 6 hours ago
              Owner

              @eiennohi why not just pass through limit: 1 here rather than changing the backend?

            • Marcelo Rivera @eiennohi changed this line in version 2 of the diff 2 hours ago

              changed this line in version 2 of the diff

            • Marcelo Rivera
              Marcelo Rivera @eiennohi · 2 hours ago
              Developer

              done. closing the other MR

            Please register or sign in to reply
          • Marcelo Rivera @eiennohi added 1 commit 2 hours ago

            added 1 commit

            • 302dc6c0 - (fix): send limit: 1 when listening from socket

            Compare with previous version

          • Marcelo Rivera @eiennohi changed the description 2 hours ago

            changed the description

          • Mark Harding @markeharding approved this merge request 1 hour ago

            approved this merge request

          • Emiliano Balbuena @edgebal approved this merge request 51 minutes ago

            approved this merge request

          • Mark Harding @markeharding merged 45 minutes ago

            merged

          • Mark Harding @markeharding mentioned in commit 291c4e63 45 minutes ago

            mentioned in commit 291c4e63

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          0
          Labels
          None
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Martin Santangelo
          user avatar
          Brian Hatchet
          user avatar
          Ben Hayward
          user avatar
          Mark Harding
          user avatar
          Emiliano Balbuena
          user avatar
          Marcelo Rivera
          Reference: minds/front!358

          Revert this merge request

          This will create a new commit in order to revert the existing changes.

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.

          Cherry-pick this merge request

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.