Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 836
    • Issues 836
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 61
    • Merge Requests 61
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !358

Open
Opened 13 hours ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

(fix): don't send offset and finish if they weren't explicitly provided

closes #380

depends on engine!211

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/eiennohi/front.git sprint/GiddyGiraffe.fix.duplicated-messages-issue-in-messenger
git checkout -b eiennohi/front-sprint/GiddyGiraffe.fix.duplicated-messages-issue-in-messenger FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff eiennohi/front-sprint/GiddyGiraffe.fix.duplicated-messages-issue-in-messenger

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge eiennohi:sprint/GiddyGiraffe.fix.duplicated-messages-issue-in-messenger into master
The source branch is 2 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #66627665 (#1939) passed for a511d6a9 on eiennohi:sprint/GiddyGiraffe.fix.duplicated-messages-issue-in-messenger
    Requires 2 more approvals from Devs.
    Martin Santangelo
    Martin Santangelo
    Mark Harding
    Mark Harding
    Ben Hayward
    Ben Hayward
    Emiliano Balbuena
    Emiliano Balbuena
    Brian Hatchet
    Brian Hatchet
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request

    Allows commits from members who can merge to the target branch

    Closes #380

    Deletes source branch

    • Discussion 1
    • Commits 1
    • Pipelines 1
    • Changes 1
    0/1 discussion resolved
    • Loading...
    • Marcelo Rivera @eiennohi mentioned in merge request engine!211 13 hours ago

      mentioned in merge request engine!211

    • Mark Harding
      Mark Harding @markeharding started a discussion on the diff 3 hours ago
      src/app/modules/messenger/conversation/conversation.component.ts
      169 167 fromSelf = true;
      170 168 }
      171 169
      172 170 this.load({ finish: message.guid });
      • Mark Harding
        Mark Harding @markeharding · 3 hours ago
        Owner

        @eiennohi why not just pass through limit: 1 here rather than changing the backend?

      Please register or sign in to reply
    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Martin Santangelo
    user avatar
    Mark Harding
    user avatar
    Ben Hayward
    user avatar
    Emiliano Balbuena
    user avatar
    Brian Hatchet
    user avatar
    Marcelo Rivera
    Reference: minds/front!358