Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 836
    • Issues 836
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 61
    • Merge Requests 61
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !334

Merged
Opened 1 week ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/GiddyGiraffe] (fix): encode objects to json in the Upload service

closes #952 (closed)

depends on engine!190 (merged)

Edited 1 week ago by Marcelo Rivera
Request to merge eiennohi:sprint/GiddyGiraffe.fix.paywall-doesnt-work-for-blogs into master
  • Email patches
  • Plain diff
Pipeline #64823254 (#1923) passed for 474a8571 on eiennohi:sprint/GiddyGiraffe.fix.paywall-doesnt-work-for-blogs
    Merge request approved. Approved by
    Mark Harding
    Mark Harding
    Ben Hayward
    Ben Hayward
    Martin Santangelo
    Martin Santangelo
    Emiliano Balbuena
    Emiliano Balbuena
    Brian Hatchet
    Brian Hatchet

    Merged by Mark Harding 7 minutes ago

    The changes were merged into master with a71c9087

    The source branch has been deleted

    Allows commits from members who can merge to the target branch

    Closed #952 (closed)

    Pipeline #66723816 (#503) running for a71c9087 on master
          • Discussion 2
          • Commits 1
          • Pipelines 1
          • Changes 1
          0/1 discussion resolved
          • Loading...
          • Marcelo Rivera @eiennohi mentioned in merge request engine!190 (merged) 1 week ago

            mentioned in merge request engine!190 (merged)

          • Marcelo Rivera @eiennohi changed the description 1 week ago

            changed the description

          • Ben Hayward @benhayward.ben approved this merge request 1 week ago

            approved this merge request

          • Mark Harding
            Mark Harding @markeharding started a discussion on the diff 1 week ago
            Last updated by Marcelo Rivera 6 days ago
            src/app/services/api/upload.ts
            35 35
            36 36 for (let key in data) {
            37 37 if (data[key] !== null) {
            38 formData.append(key, data[key]);
            38 const field = typeof data[key] == 'object' ? JSON.stringify(data[key]) : data[key];
            • Mark Harding
              Mark Harding @markeharding · 1 week ago
              Owner

              @eiennohi is php expecting json? Is there a backend fix here. Just want to be sure we don't break something

            • Marcelo Rivera
              Marcelo Rivera @eiennohi · 6 days ago
              Developer

              backend MR: engine!190 (merged)

              By the way, I quickly checked all features that make use of the UploadService and the blog editor seems to be the only one sending nested objects, so this fix should only affect blogs.

            Please register or sign in to reply
          • Mark Harding @markeharding approved this merge request 7 minutes ago

            approved this merge request

          • Mark Harding @markeharding merged 7 minutes ago

            merged

          • Mark Harding @markeharding mentioned in commit a71c9087 7 minutes ago

            mentioned in commit a71c9087

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          0
          Labels
          None
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Martin Santangelo
          user avatar
          Emiliano Balbuena
          user avatar
          Brian Hatchet
          user avatar
          Mark Harding
          user avatar
          Marcelo Rivera
          user avatar
          Ben Hayward
          Reference: minds/front!334

          Revert this merge request

          This will create a new commit in order to revert the existing changes.

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.

          Cherry-pick this merge request

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.