Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 833
    • Issues 833
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 61
    • Merge Requests 61
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !174

Open
Opened 3 months ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/Subscribers](feat): Delete all owned content comments.

Addressing minds#215

This task was initially for blogs only but after speaking with Jack, it appears its a requested feature for all forms of media & content.

This should really be tested, but could not fit the time into the task weight as there isn't already tests set-up in this area.

Can either merge now and test later, or pass it back around to me in this weeks sprint @markeharding

Edited 3 months ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git delete-all-owned-content-comments
git checkout -b benhayward.ben/front-delete-all-owned-content-comments FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-delete-all-owned-content-comments

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:delete-all-owned-content-comments into master
The source branch is 400 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #66293925 (#901) passed for b092fbdc on benhayward.ben:delete-all-owned-content-comments
    Requires 2 more approvals.
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request

    Allows commits from members who can merge to the target branch

    Mentions minds#215

    Deletes source branch

    • Discussion 1
    • Commits 3
    • Pipelines 3
    • Changes 4
    • Loading...
    • Ben Hayward @benhayward.ben changed the description 3 months ago

      changed the description

    • Ben Hayward @benhayward.ben added 1 commit 2 days ago

      added 1 commit

      • b092fbdc - Update list.component.ts

      Compare with previous version

    • Mark Harding
      Mark Harding @markeharding · 2 hours ago
      Owner

      I'm unsure how this fixes the issue. Comment trees are initialized from m-comments_tree which passes through [entity] to all children.

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    2
    2 participants
    user avatar
    Mark Harding
    user avatar
    Ben Hayward
    Reference: minds/front!174