Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 828
    • Issues 828
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 62
    • Merge Requests 62
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !354

Merged
Opened 3 days ago by Olivia Madrid@omadrid
  • Report abuse
Report abuse

Style/interactivity updates for some button toolbars and minor UI quirk fixes

Buttons

Made buttons on the same toolbar the same color as one another and/or make them darker on hover. Only applies to some toolbars/buttons - lots more remain. Includes:

  • activity action tabs
  • comment action buttons
  • messenger conversation buttons
  • remind composer buttons
  • toolbars on blogs
  • comment button toolbar

Quirks

  • removed hover background on disabled pin button
  • removed cursor:pointer from some non-actionable items (activity metrics, admin tooltip bubble)
  • fixed bug where badge tooltips of verified remind posters were partially hidden

Applies to issues #1397 and #1384

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/omadrid/front.git postCardUIUpdate
git checkout -b omadrid/front-postCardUIUpdate FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff omadrid/front-postCardUIUpdate

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge omadrid:postCardUIUpdate into master
  • Email patches
  • Plain diff
Pipeline #66150812 (#36) passed for f157e3e9 on omadrid:postCardUIUpdate
    Merge request approved. Approved by
    Ben Hayward
    Ben Hayward
    Mark Harding
    Mark Harding
    Brian Hatchet
    Brian Hatchet
    Marcelo Rivera
    Marcelo Rivera
    Martin Santangelo
    Martin Santangelo
    Emiliano Balbuena
    Emiliano Balbuena

    Merged by Mark Harding 5 minutes ago

    The changes were merged into master with d51b6c53

    Mentions #1384 and #1397

    Pipeline #66498130 (#500) running for d51b6c53 on master
          • Discussion 0
          • Commits 10
          • Pipelines 1
          • Changes 11
          • Loading...
          • Mark Harding @markeharding approved this merge request 2 days ago

            approved this merge request

          • Ben Hayward @benhayward.ben approved this merge request 2 days ago

            approved this merge request

          • Mark Harding @markeharding merged 5 minutes ago

            merged

          • Mark Harding @markeharding mentioned in commit d51b6c53 5 minutes ago

            mentioned in commit d51b6c53

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          0
          Labels
          None
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          7
          7 participants
          user avatar
          Brian Hatchet
          user avatar
          Marcelo Rivera
          user avatar
          Martin Santangelo
          user avatar
          Emiliano Balbuena
          user avatar
          Mark Harding
          user avatar
          Ben Hayward
          user avatar
          Olivia Madrid
          Reference: minds/front!354

          Revert this merge request

          This will create a new commit in order to revert the existing changes.

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.

          Cherry-pick this merge request

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.