[Sprint/GiddyGiraffe](feat): Added in a warning if the user tries entering an email #331
Edited by Ben Hayward
Request to merge benhayward.ben:login-warn-on-email-entered into master
The source branch is 22 commits behind the target branch
2/3 discussions resolved
changed the description
approved this merge request
approved this merge request
Resolved by Ben Hayward- Resolved by Ben Hayward
resolved all discussions
39 38 if (this.inProgress) 40 39 return; 41 40 41 let username = this.form.value.username.trim(); 42 if (username.includes('@') && username.indexOf('@') != 0) { - Owner
This is still inaccurate. An @ symbol doesn't imply that its an email. We should be detecting a domain too.
Please register or sign in to reply
