Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 825
    • Issues 825
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 63
    • Merge Requests 63
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !345

Merged
Opened 2 days ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/GiddyGiraffe] (fix): group chat closes when scrolling on mobile web

closes #1394 (closed)

The issue was caused by Chrome's navigation bar (dis)appearing on scroll, which triggered the window:resize event ( https://developers.google.com/web/updates/2016/12/url-bar-resizing )

Request to merge eiennohi:sprint/GiddyGiraffe.fix.group-chat-closes-when-scrolling-on-mobile into master
  • Email patches
  • Plain diff
Pipeline #65676869 (#1928) passed for 2ce50e05 on eiennohi:sprint/GiddyGiraffe.fix.group-chat-closes-when-scrolling-on-mobile
    Merge request approved. Approved by
    Ben Hayward
    Ben Hayward
    Brian Hatchet
    Brian Hatchet
    Emiliano Balbuena
    Emiliano Balbuena
    Mark Harding
    Mark Harding
    Martin Santangelo
    Martin Santangelo

    Merged by Mark Harding 7 minutes ago

    The changes were merged into master with 5dc84418

    The source branch has been deleted

    Allows commits from members who can merge to the target branch

    Closed #1394 (closed)

    Pipeline #66185547 (#497) running for 5dc84418 on master
          • Discussion 0
          • Commits 1
          • Pipelines 1
          • Changes 1
          • Loading...
          • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 2 days ago

            approved this merge request

          • Ben Hayward @benhayward.ben approved this merge request 2 days ago

            approved this merge request

          • Mark Harding @markeharding merged 7 minutes ago

            merged

          • Mark Harding @markeharding mentioned in commit 5dc84418 7 minutes ago

            mentioned in commit 5dc84418

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          0
          Labels
          None
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Emiliano Balbuena
          user avatar
          Mark Harding
          user avatar
          Martin Santangelo
          user avatar
          Ben Hayward
          user avatar
          Brian Hatchet
          user avatar
          Marcelo Rivera
          Reference: minds/front!345

          Revert this merge request

          This will create a new commit in order to revert the existing changes.

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.

          Cherry-pick this merge request

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.