Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 146
    • Issues 146
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 35
    • Merge Requests 35
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !120

Open
Opened 2 months ago by Emiliano Balbuena@edgebal
  • Report abuse
Report abuse

Ban and artifacts snapshots

CQL Schema changes:

CREATE TABLE minds.user_snapshots (
  user_guid varint,
  type text,
  key text,
  json_data text,
  PRIMARY KEY (user_guid, type, key)
) WITH CLUSTERING ORDER BY (type ASC, key ASC);
Edited 2 months ago by Emiliano Balbuena

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/edgebal/engine.git sprint/Wire.feat.ban-snapshot-1
git checkout -b edgebal/engine-sprint/Wire.feat.ban-snapshot-1 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff edgebal/engine-sprint/Wire.feat.ban-snapshot-1

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge edgebal:sprint/Wire.feat.ban-snapshot-1 into master
The source branch is 3 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #65918050 (#554) passed for 1b9c9dd7 on edgebal:sprint/Wire.feat.ban-snapshot-1
      Requires 2 more approvals.
      Ready to be merged automatically. Ask someone with write access to this repository to merge this request

      Allows commits from members who can merge to the target branch

      Deletes source branch

      • Discussion 25
      • Commits 40
      • Pipelines 37
      • Changes 62
      17/17 discussions resolved
      • Loading...
      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • 9b179a3f - (proto): Posts, Comments and Subscriptions/Subscribers delegates

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • 31e5b67d - (proto): Move to Artifacts, comments should snapshot entity

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • 0a56c136 - (proto): Move to Artifacts, comments should snapshot entity

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • a58db9ea - (chore): Key serialization, snapshotable comments

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • f19ff274 - (chore): Always use delegates, fix comments and subs, CLI utility

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • b8357327 - (test): Fix existing tests

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • 11cf756b - (refactor): Adapt to ban implementation; queue runner

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • 23ffe58c - (test): Fix existing spec tests

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • 20876b2f - (test): Add Channels\Manager new methods and Channels\Snapshot

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • 64ee6ef2 - (feat): ElasticSearch Snapshot/Delete/Restore

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • 3a96087d - (test): Fix spec tests

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • 899b3d9a - (test): Artifacts Delegate spec tests

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • 3655dc95 - (test): Ban/Unban spec test

        Compare with previous version

      • Emiliano Balbuena @edgebal unmarked as a Work In Progress 2 months ago

        unmarked as a Work In Progress

      • Emiliano Balbuena @edgebal changed the description 2 months ago

        changed the description

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • deea7f99 - (refactor): Use DeleteByQuery

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • 50ad26f7 - (test): Elasticsearch delegate spec tests

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • 6742969e - (test): Posts delegate spec test

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • e504da6e - (feat): Restore inverse relationship on subs

        Compare with previous version

      • Mark Harding
        Mark Harding @markeharding started a discussion on the diff 2 months ago
        Resolved by Mark Harding 2 months ago
      • Mark Harding
        Mark Harding @markeharding started a discussion on the diff 2 months ago
        Resolved by Emiliano Balbuena 3 hours ago
      • Mark Harding
        Mark Harding @markeharding started a discussion on the diff 2 months ago
        Resolved by Emiliano Balbuena 2 months ago
      • Mark Harding
        Mark Harding @markeharding started a discussion on the diff 2 months ago
        Resolved by Emiliano Balbuena 2 months ago
      • Mark Harding
        Mark Harding @markeharding started a discussion on an old version of the diff 2 months ago
        Resolved by Emiliano Balbuena 3 hours ago
      • Mark Harding
        Mark Harding @markeharding started a discussion on an old version of the diff 2 months ago
        Resolved by Emiliano Balbuena 3 hours ago
      • Mark Harding
        Mark Harding @markeharding started a discussion on an old version of the diff 2 months ago
        Resolved by Emiliano Balbuena 3 hours ago
      • Emiliano Balbuena @edgebal added 2 commits 2 months ago

        added 2 commits

        • 12a1a2ab - (chore): Refactor big if statements
        • 0a81bdb0 - (refactor): Use getList and $opts

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • 63bf7ddc - (refactor): Separate ban logic from Manager

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • ff7e6ca0 - (feat): Deletion as background task

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 months ago

        added 1 commit

        • 78656a10 - (feat): Deletion as background task

        Compare with previous version

      • Emiliano Balbuena @edgebal added 2 commits 2 months ago

        added 2 commits

        • 852e7375 - (fix): User entity deletion should delete artifacts
        • 4a04ab7c - (refactor): Serialize comment during snapshot

        Compare with previous version

      • Emiliano Balbuena @edgebal added 257 commits 2 weeks ago

        added 257 commits

        • 4a04ab7c...8bd9d70c - 256 commits from branch minds:master
        • dd0940ad - Merge branch 'master' into sprint/Wire.feat.ban-snapshot-1

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

        added 1 commit

        • 3af444b0 - (refactor): Use subscribe()/unSubscribe() methods on snapshots (#461)

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

        added 1 commit

        • 4e56b2c7 - (fix): Force comment deleting on queue

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

        added 1 commit

        • 1a28364e - (feat): Process subscriptions/subscribers by batches

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 2 weeks ago

        added 1 commit

        • ec9ed48a - (test): Fix spec tests

        Compare with previous version

      • Emiliano Balbuena @edgebal added 2 commits 2 weeks ago

        added 2 commits

        • 9023c045 - (feat): Cassandra Scroll helper class
        • 8c808555 - (refactor): Use Scroll class to traverse friends tables

        Compare with previous version

      • Mark Harding
        Mark Harding @markeharding started a discussion on an old version of the diff 2 weeks ago
        Resolved by Emiliano Balbuena 3 hours ago
      • Mark Harding
        Mark Harding @markeharding started a discussion on an old version of the diff 2 weeks ago
        Resolved by Emiliano Balbuena 3 hours ago
      • Mark Harding
        Mark Harding @markeharding started a discussion on an old version of the diff 2 weeks ago
        Resolved by Emiliano Balbuena 3 hours ago
      • Mark Harding
        Mark Harding @markeharding started a discussion on an old version of the diff 2 weeks ago
        Resolved by Emiliano Balbuena 3 hours ago
      • Mark Harding
        Mark Harding @markeharding started a discussion on an old version of the diff 2 weeks ago
        Resolved by Emiliano Balbuena 3 hours ago
      • Mark Harding
        Mark Harding @markeharding started a discussion on an old version of the diff 2 weeks ago
        Resolved by Emiliano Balbuena 3 hours ago
      • Mark Harding
        Mark Harding @markeharding started a discussion on the diff 2 weeks ago
        Resolved by Emiliano Balbuena 3 hours ago
      • Mark Harding
        Mark Harding @markeharding started a discussion on the diff 2 weeks ago
        Resolved by Emiliano Balbuena 3 hours ago
      • Mark Harding
        Mark Harding @markeharding started a discussion on an old version of the diff 2 weeks ago
        Resolved by Emiliano Balbuena 3 hours ago
      • Mark Harding
        Mark Harding @markeharding started a discussion on the diff 2 weeks ago
        Resolved by Emiliano Balbuena 3 hours ago
      • Mark Harding
        Mark Harding @markeharding · 2 weeks ago
        Owner

        I think we can greatly simplify/optimise the delete/snapshot stuff

        • No need to snapshot/restore personal indexes
        • No need to snapshot/restore lookup indexes
        • No need to snapshot/restore entities (they can just add the 'delete' boolean to them)
        • No need to download from ES (a boolean on all the owner_guids documents should suffice)
        • There needs to be a distinction between hiding/deleting. I would just add another function called hide(), and if it is a delete operation for that delegate, it will just pass though as delete
      • Emiliano Balbuena @edgebal added 16 commits 1 week ago

        added 16 commits

        • 8c808555...9b4c685a - 15 commits from branch minds:master
        • 6cba56f6 - Merge remote-tracking branch 'upstream/master' into sprint/Wire.feat.ban-snapshot-1

        Compare with previous version

      • Emiliano Balbuena @edgebal added 9 commits 1 week ago

        added 9 commits

        • 6cba56f6...678abba9 - 8 commits from branch minds:master
        • a552f1de - Merge branch 'master' into sprint/Wire.feat.ban-snapshot-1

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 1 week ago

        added 1 commit

        • 03070565 - (refactor): Add hide() and optimize/simplify processes

        Compare with previous version

      • Emiliano Balbuena @edgebal added 2 commits 1 week ago

        added 2 commits

        • fea5e2ab - (chore): Code cleanup; (fix): Process hidden user entities
        • a253b54e - (chore): Posts delegate should be UserEntities

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 1 week ago

        added 1 commit

        • 0d7a2e1e - (test): Fix spec tests

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 1 week ago

        added 1 commit

        • 85776525 - (refactor): Snapshot CLI allow banning

        Compare with previous version

      • Emiliano Balbuena @edgebal added 25 commits 5 hours ago

        added 25 commits

        • 85776525...a11370c5 - 24 commits from branch minds:master
        • a82b01ae - Merge remote-tracking branch 'upstream/master' into sprint/Wire.feat.ban-snapshot-1

        Compare with previous version

      • Emiliano Balbuena @edgebal added 1 commit 3 hours ago

        added 1 commit

        • 1b9c9dd7 - (chore): Use string as queue name; use DI for Channels classes

        Compare with previous version

      • Emiliano Balbuena @edgebal resolved all discussions 3 hours ago

        resolved all discussions

      • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
      Please register or sign in to reply
      Assignee
      Emiliano Balbuena's avatar Emiliano Balbuena @edgebal
      Assign to
      None
      Milestone
      None
      Assign milestone
      None
      Time tracking
      No estimate or time spent
      0
      Labels
      None
      Assign labels
      • View project labels
      Lock merge request
      Unlocked
      2
      2 participants
      user avatar
      Emiliano Balbuena
      user avatar
      Mark Harding
      Reference: minds/engine!120