[Sprint/GiddyGiraffe](feat): Added in a warning if the user tries entering an email #331
Edited by Ben Hayward
Request to merge benhayward.ben:login-warn-on-email-entered into master
The source branch is 14 commits behind the target branch
0/2 discussions resolved
changed the description
approved this merge request
approved this merge request
39 38 if (this.inProgress) 40 39 return; 41 40 41 if (this.form.value.username.includes('@')) { 
OwnerCondition here does not prove its an email. It could very well be their username with a @ at the start, so I think there should be an extra check here.
37 37 i18n="@@MINDS__LOGIN__EXCEPTION__INVALID_TOKEN"> 38 38 Invalid token 39 39 </ng-container> 40 <ng-container 41 *ngIf="errorMessage == 'LoginException::EmailAddress'" 42 i18n="@@MINDS__LOGIN__EXCEPTION__ENTERED_EMAIL_ADDRESS_NOT_USERNAME"> 43 You've entered a email address rather than a username. - Owner
Change to "Please enter a username instead of an email address".
