Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 145
    • Issues 145
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 38
    • Merge Requests 38
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !195

Merged
Opened 2 days ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/GiddyGiraffe] (fix): strip hash character from search

closes #503 (closed)

Request to merge eiennohi:sprint/GiddyGiraffe.feat.strip-hash-character-from-search into master
  • Email patches
  • Plain diff
Pipeline #65664255 (#954) passed for 0471e32c on eiennohi:sprint/GiddyGiraffe.feat.strip-hash-character-from-search
      Merge request approved. Approved by
      Ben Hayward
      Ben Hayward
      Mark Harding
      Mark Harding
      Emiliano Balbuena
      Emiliano Balbuena
      Rami Albatal
      Rami Albatal
      Brian Hatchet
      Brian Hatchet
      Martin Santangelo
      Martin Santangelo

      Merged by Mark Harding 2 hours ago

      The changes were merged into master with a8615d03

      The source branch has been deleted

      Allows commits from members who can merge to the target branch

      Closed #503 (closed)

      Pipeline #65670705 (#746) passed for a8615d03 on master
            • Discussion 2
            • Commits 3
            • Pipelines 2
            • Changes 4
            0/1 discussion resolved
            • Loading...
            • Mark Harding @markeharding approved this merge request 1 day ago

              approved this merge request

            • Mark Harding
              Mark Harding @markeharding started a discussion on an old version of the diff 1 day ago
              Last updated by Marcelo Rivera 3 hours ago
              Controllers/api/v2/feeds.php
              123 123
              124 124 $query = null;
              125 125 if (isset($_GET['query'])) {
              126 $query = strtolower($_GET['query']);
              126 $query = str_replace('#', '', strtolower($_GET['query']));
              • Mark Harding
                Mark Harding @markeharding · 1 day ago
                Owner

                can we move both of these logics (remove hashtag + lower case) to Core along with spec tests?

              • Marcelo Rivera @eiennohi changed this line in version 2 of the diff 3 hours ago

                changed this line in version 2 of the diff

              Please register or sign in to reply
            • Marcelo Rivera @eiennohi added 2 commits 3 hours ago

              added 2 commits

              • 3d9b51c0 - (fix): moved lowercase and strip hashtag logic to Manager
              • 0471e32c - (feat): spec test

              Compare with previous version

            • Mark Harding @markeharding approved this merge request 3 hours ago

              approved this merge request

            • Mark Harding
              Mark Harding @markeharding · 3 hours ago
              Owner

              @all please approve

            • Ben Hayward @benhayward.ben approved this merge request 2 hours ago

              approved this merge request

            • Mark Harding @markeharding mentioned in commit a8615d03 2 hours ago

              mentioned in commit a8615d03

            • Mark Harding @markeharding merged 2 hours ago

              merged

            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
            Please register or sign in to reply
            Assignee
            None
            Assign to
            None
            Milestone
            None
            Assign milestone
            None
            Time tracking
            No estimate or time spent
            0
            Labels
            None
            Assign labels
            • View project labels
            Lock merge request
            Unlocked
            15
            15 participants
            user avatar
            Emiliano Balbuena
            user avatar
            Rami Albatal
            user avatar
            Brian Hatchet
            user avatar
            Martin Santangelo
            user avatar
            Mark Harding
            user avatar
            Ben Hayward
            user avatar
            Marcelo Rivera
            Reference: minds/engine!195

            Revert this merge request

            This will create a new commit in order to revert the existing changes.

            Switch branch
            Cancel
            A new branch will be created in your fork and a new merge request will be started.

            Cherry-pick this merge request

            Switch branch
            Cancel
            A new branch will be created in your fork and a new merge request will be started.