Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 820
    • Issues 820
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 61
    • Merge Requests 61
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !334

Open
Opened 6 days ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/GiddyGiraffe] (fix): encode objects to json in the Upload service

closes #952

depends on engine!190

Edited 6 days ago by Marcelo Rivera

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/eiennohi/front.git sprint/GiddyGiraffe.fix.paywall-doesnt-work-for-blogs
git checkout -b eiennohi/front-sprint/GiddyGiraffe.fix.paywall-doesnt-work-for-blogs FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff eiennohi/front-sprint/GiddyGiraffe.fix.paywall-doesnt-work-for-blogs

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge eiennohi:sprint/GiddyGiraffe.fix.paywall-doesnt-work-for-blogs into master
The source branch is 12 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #64823254 (#1923) passed for 474a8571 on eiennohi:sprint/GiddyGiraffe.fix.paywall-doesnt-work-for-blogs
    Requires approval from Devs. Approved by
    Ben Hayward
    Ben Hayward
    Emiliano Balbuena
    Emiliano Balbuena
    Brian Hatchet
    Brian Hatchet
    Martin Santangelo
    Martin Santangelo
    Mark Harding
    Mark Harding
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request

    Allows commits from members who can merge to the target branch

    Closes #952

    Deletes source branch

    • Discussion 2
    • Commits 1
    • Pipelines 1
    • Changes 1
    0/1 discussion resolved
    • Loading...
    • Marcelo Rivera @eiennohi mentioned in merge request engine!190 6 days ago

      mentioned in merge request engine!190

    • Marcelo Rivera @eiennohi changed the description 6 days ago

      changed the description

    • Ben Hayward @benhayward.ben approved this merge request 5 days ago

      approved this merge request

    • Mark Harding
      Mark Harding @markeharding started a discussion on the diff 22 hours ago
      Last updated by Marcelo Rivera 1 hour ago
      src/app/services/api/upload.ts
      35 35
      36 36 for (let key in data) {
      37 37 if (data[key] !== null) {
      38 formData.append(key, data[key]);
      38 const field = typeof data[key] == 'object' ? JSON.stringify(data[key]) : data[key];
      • Mark Harding
        Mark Harding @markeharding · 22 hours ago
        Owner

        @eiennohi is php expecting json? Is there a backend fix here. Just want to be sure we don't break something

      • Marcelo Rivera
        Marcelo Rivera @eiennohi · 1 hour ago
        Developer

        backend MR: engine!190

        By the way, I quickly checked all features that make use of the UploadService and the blog editor seems to be the only one sending nested objects, so this fix should only affect blogs.

      Please register or sign in to reply
    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Emiliano Balbuena
    user avatar
    Brian Hatchet
    user avatar
    Martin Santangelo
    user avatar
    Mark Harding
    user avatar
    Marcelo Rivera
    user avatar
    Ben Hayward
    Reference: minds/front!334