Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 818
    • Issues 818
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 60
    • Merge Requests 60
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !321

Closed
Opened 1 week ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/FunnyFrog](bug): Added in counter for comments and alert. #452

Closing #452 (closed)

I decided rather than throwing an alert at the user, it'd be better to let them write or paste in what they want, and then cut it down to the appropriate length.

Counter is hidden if comment is empty as normal.

image

Without the error bar.

image

With the error bar.

image

image

image

Edited 1 week ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git comment-length-indicator-and-error-452
git checkout -b benhayward.ben/front-comment-length-indicator-and-error-452 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-comment-length-indicator-and-error-452

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:comment-length-indicator-and-error-452 into master
  • Email patches
  • Plain diff
Pipeline #65657238 (#891) running for 9277a8b7 on benhayward.ben:comment-length-indicator-and-error-452
    Requires 2 more approvals from Devs.
    Marcelo Rivera
    Marcelo Rivera
    Emiliano Balbuena
    Emiliano Balbuena
    Brian Hatchet
    Brian Hatchet
    Martin Santangelo
    Martin Santangelo
    Mark Harding
    Mark Harding

    Closed by Mark Harding 3 minutes ago

    The changes were not merged into master

    Allows commits from members who can merge to the target branch

    Did not close #452 (closed)

    Deletes source branch

    • Discussion 7
    • Commits 6
    • Pipelines 6
    • Changes 3
    4/4 discussions resolved
    • Loading...
    • Ben Hayward @benhayward.ben changed the description 1 week ago

      changed the description

    • Mark Harding
      Mark Harding @markeharding started a discussion on an old version of the diff 1 week ago
      Resolved by Ben Hayward 1 week ago
    • Mark Harding
      Mark Harding @markeharding started a discussion on an old version of the diff 1 week ago
      Resolved by Ben Hayward 1 week ago
    • Mark Harding
      Mark Harding @markeharding started a discussion on an old version of the diff 1 week ago
      Resolved by Ben Hayward 1 week ago
    • Ben Hayward @benhayward.ben added 1 commit 1 week ago

      added 1 commit

      • 40a70b69 - small refactor and css name change

      Compare with previous version

    • Ben Hayward @benhayward.ben added 1 commit 1 week ago

      added 1 commit

      • 1829ba73 - adding theming

      Compare with previous version

    • Ben Hayward
      Ben Hayward @benhayward.ben · 1 week ago
      Developer

      Discussed in meeting, moving this over to a change detection system

    • Ben Hayward @benhayward.ben added 1 commit 1 week ago

      added 1 commit

      • f3676671 - refactored

      Compare with previous version

    • Ben Hayward @benhayward.ben resolved all discussions 1 week ago

      resolved all discussions

    • Mark Harding
      Mark Harding @markeharding started a discussion on the diff 5 days ago
      Resolved by Ben Hayward 5 days ago
    • Ben Hayward @benhayward.ben added 1 commit 5 days ago

      added 1 commit

      • 716b99ab - Update poster.component.html

      Compare with previous version

    • Ben Hayward @benhayward.ben resolved all discussions 5 days ago

      resolved all discussions

    • Mark Harding @markeharding added 1 commit 4 minutes ago

      added 1 commit

      • 9277a8b7 - (feat): improve ui max comments

      Compare with previous version

    • Mark Harding @markeharding closed 3 minutes ago

      closed

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Marcelo Rivera
    user avatar
    Emiliano Balbuena
    user avatar
    Brian Hatchet
    user avatar
    Martin Santangelo
    user avatar
    Mark Harding
    user avatar
    Ben Hayward
    Reference: minds/front!321