Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 819
    • Issues 819
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 60
    • Merge Requests 60
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !333

Open
Opened 5 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/FunnyFrog](feat): Preferred hashtag remember local storage 1302

Works fine by my testing. Removed this.lastPreferredEmission so that the system just uses localStorage to determine its value, rather than storing the last state of it when navigating away and back.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git preferred-hashtag-remember-local-storage-1302
git checkout -b benhayward.ben/front-preferred-hashtag-remember-local-storage-1302 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-preferred-hashtag-remember-local-storage-1302

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:preferred-hashtag-remember-local-storage-1302 into master
The source branch is 10 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #64691344 (#880) passed for 9273711d on benhayward.ben:preferred-hashtag-remember-local-storage-1302
    Requires 2 more approvals from Devs.
    Marcelo Rivera
    Marcelo Rivera
    Emiliano Balbuena
    Emiliano Balbuena
    Brian Hatchet
    Brian Hatchet
    Martin Santangelo
    Martin Santangelo
    Mark Harding
    Mark Harding
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request

    Allows commits from members who can merge to the target branch

    Deletes source branch

    • Discussion 1
    • Commits 2
    • Pipelines 2
    • Changes 1
    0/1 discussion resolved
    • Loading...
    • Mark Harding
      Mark Harding @markeharding started a discussion on the diff 18 minutes ago
      src/app/modules/hashtags/sidebar-selector/sidebar-selector.component.ts
      46 44 }
      47 45
      48 46 ngOnInit() {
      49 this.lastPreferredEmission = this.preferred;
      47 this.preferred = localStorage.getItem('preferred_hashtag_state') === 'true';
      • Mark Harding
        Mark Harding @markeharding · 18 minutes ago
        Owner

        please use storage class vs localStorage

      Please register or sign in to reply
    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Marcelo Rivera
    user avatar
    Emiliano Balbuena
    user avatar
    Brian Hatchet
    user avatar
    Martin Santangelo
    user avatar
    Mark Harding
    user avatar
    Ben Hayward
    Reference: minds/front!333