Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 816
    • Issues 816
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 61
    • Merge Requests 61
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !343

Open
Opened 6 hours ago by Mark Harding@markeharding0 of 3 tasks completed0/3 tasks
  • Report abuse
Report abuse

Epic/ssr

Angular Universal implementation

Running

ng run v5.x:server:production && webpack --config webpack.server.config.js --progress --colors

TODO

  • Only render below the fold requests on scroll as SEO crawlers are still waiting for the DOM to be kicked off.
  • Implement security and cookie forwarding
  • Dynamic domain vs hard coded in client

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b epic/SSR origin/epic/SSR

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff epic/SSR

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge epic/SSR into master
The source branch is 10 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #65460743 (#484) failed for 5263c95a on epic/SSR
    Requires 2 more approvals from Devs.
    Marcelo Rivera
    Marcelo Rivera
    Ben Hayward
    Ben Hayward
    Emiliano Balbuena
    Emiliano Balbuena
    Martin Santangelo
    Martin Santangelo
    Brian Hatchet
    Brian Hatchet
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request
    • Discussion 0
    • Commits 1
    • Pipelines 2
    • Changes 44
    • Loading...
    • Mark Harding @markeharding added 1 commit 6 hours ago

      added 1 commit

      • 5263c95a - (wip): Server Side Rendering - work in progress

      Compare with previous version

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Marcelo Rivera
    user avatar
    Ben Hayward
    user avatar
    Emiliano Balbuena
    user avatar
    Martin Santangelo
    user avatar
    Brian Hatchet
    user avatar
    Mark Harding
    Reference: minds/front!343