Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 146
    • Issues 146
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 36
    • Merge Requests 36
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !191

Open
Opened 3 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

WIP: Add in delegate for checking for onchain badge

Edited 11 hours ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/engine.git onchain-badge-backend-additions
git checkout -b benhayward.ben/engine-onchain-badge-backend-additions FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/engine-onchain-badge-backend-additions

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:onchain-badge-backend-additions into master
The source branch is 6 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #65403872 passed for e17b138c on benhayward.ben:onchain-badge-backend-additions
      Requires 2 more approvals from Devs.
      Martin Santangelo
      Martin Santangelo
      Marcelo Rivera
      Marcelo Rivera
      Brian Hatchet
      Brian Hatchet
      Emiliano Balbuena
      Emiliano Balbuena
      Rami Albatal
      Rami Albatal
      This is a Work in Progress
      Allows commits from members who can merge to the target branch

      Deletes source branch

      You can merge this merge request manually using the
      • Discussion 5
      • Commits 13
      • Pipelines 10
      • Changes 6
      0/5 discussions resolved
      • Loading...
      • Ben Hayward @benhayward.ben added 1 commit 2 days ago

        added 1 commit

        • b47d4b3d - Moved to delegate, and only triggering on one tx

        Compare with previous version

      • Ben Hayward @benhayward.ben added 1 commit 2 days ago

        added 1 commit

        • 7ff4b980 - Quickfix

        Compare with previous version

      • Ben Hayward @benhayward.ben added 2 commits 2 days ago

        added 2 commits

        • 22bb5263 - Removing unneeded code
        • 3cf676c5 - Removing unneeded imports

        Compare with previous version

      • Ben Hayward @benhayward.ben added 1 commit 2 days ago

        added 1 commit

        • b2e2cf95 - Refactoring, moving things around

        Compare with previous version

      • Ben Hayward @benhayward.ben added 1 commit 2 days ago

        added 1 commit

        • e5676609 - Small update to bookmark progress

        Compare with previous version

      • Ben Hayward @benhayward.ben added 1 commit 1 day ago

        added 1 commit

        • 2402b1fe - Refactored and fixed up failing tests

        Compare with previous version

      • Ben Hayward @benhayward.ben added 2 commits 11 hours ago

        added 2 commits

        • e519c40f - Added spec tests for OnchainBadge
        • b1d3afe4 - Cleaning up a little bit

        Compare with previous version

      • Ben Hayward @benhayward.ben changed title from WIP: Add in event for checking for onchain badge to WIP: Add in delegate for checking for onchain badge 11 hours ago

        changed title from WIP: Add in event for checking for onchain badge to WIP: Add in delegate for checking for onchain badge

      • Ben Hayward @benhayward.ben added 1 commit 11 hours ago

        added 1 commit

        • 76b5f006 - Update ReviewSpec.php

        Compare with previous version

      • Ben Hayward @benhayward.ben added 2 commits 11 hours ago

        added 2 commits

        • f2f22d87 - line spacing
        • e17b138c - Added test for onchain booster status

        Compare with previous version

      • Mark Harding
        Mark Harding @markeharding started a discussion on the diff 31 minutes ago
        Core/Boost/Delegates/OnchainBadge.php
        1 <?php
        2
        3 /**
        4 * Onchain badge granting delegate.
        5 *
        6 * @author Ben Hayward
        7 */
        8
        9 namespace Minds\Core\Boost\Delegates;
        10
        11 use Minds\Core\Boost\Network\Boost;
        12
        13 class OnchainBadge
        • Mark Harding
          Mark Harding @markeharding · 31 minutes ago
          Owner

          Change to OnchainBadgeDelegate. You should notice all delegates following this naming scheme.

        Please register or sign in to reply
      • Mark Harding
        Mark Harding @markeharding started a discussion on the diff 30 minutes ago
        Core/Boost/Network/Review.php
        64 71 }
        65 72 $success = Core\Di\Di::_()->get('Boost\Payment')->charge($this->boost);
        66 73 if ($success) {
        74 $this->onchainBadge->dispatch($this->boost);
        • Mark Harding
          Mark Harding @markeharding · 30 minutes ago
          Owner

          Need to confirm that it is indeed an onchain boost?

        Please register or sign in to reply
      • Mark Harding
        Mark Harding @markeharding started a discussion on the diff 30 minutes ago
        Entities/User.php
        1044 1047 return "urn:user:{$this->getGuid()}";
        1045 1048 }
        1046 1049
        1050 public function isOnchainBooster()
        1051 {
        1052 return (int) $this->onchain_booster;
        • Mark Harding
          Mark Harding @markeharding · 30 minutes ago
          Owner

          is would imply a boolean

        Please register or sign in to reply
      • Mark Harding
        Mark Harding @markeharding started a discussion on the diff 29 minutes ago
        Spec/Core/Boost/Delegates/OnchainBadgeSpec.php
        15
        16 class OnchainBadgeSpec extends ObjectBehavior
        17 {
        18
        19 function it_is_initializable()
        20 {
        21 $this->shouldHaveType(OnchainBadge::class);
        22 }
        23
        24 function it_should_update_a_users_plus_badge_expiry(Boost $boost, User $user)
        25 {
        26 $boost->getOwner()
        27 ->shouldBeCalled()
        28 ->willReturn($user);
        29
        30 $user->setOnchainBooster(Argument::any())
        • Mark Harding
          Mark Harding @markeharding · 29 minutes ago
          Owner

          should we not check the time is set correctly?

        Please register or sign in to reply
      • Mark Harding
        Mark Harding @markeharding started a discussion on the diff 29 minutes ago
        Spec/Core/Boost/Network/ReviewSpec.php
        50 54 ->during('accept');
        51 55 }
        52 56
        53 function it_should_accept_a_boost(Payment $payment, Boost $boost)
        57 function it_should_accept_a_boost(Payment $payment, Boost $boost, User $user)
        54 58 {
        59 $boost = new Boost();
        60 $boost->setOwner($user);
        61
        • Mark Harding
          Mark Harding @markeharding · 29 minutes ago
          Owner

          test to ensure delegate was called?

        Please register or sign in to reply
      • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
      Please register or sign in to reply
      Assignee
      None
      Assign to
      None
      Milestone
      None
      Assign milestone
      None
      Time tracking
      No estimate or time spent
      0
      Labels
      None
      Assign labels
      • View project labels
      Lock merge request
      Unlocked
      7
      7 participants
      user avatar
      Martin Santangelo
      user avatar
      Marcelo Rivera
      user avatar
      Brian Hatchet
      user avatar
      Emiliano Balbuena
      user avatar
      Rami Albatal
      user avatar
      Mark Harding
      user avatar
      Ben Hayward
      Reference: minds/engine!191