Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 143
    • Issues 143
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 34
    • Merge Requests 34
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !193

Open
Opened 2 hours ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/GiddyGiraffe] (fix): banning does not stop users from commenting on group activities

closes front#1354

Edited 2 hours ago by Marcelo Rivera

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/eiennohi/engine.git sprint/GiddyGiraffe.fix.dont-allow-commenting-on-activities-from-groups-youre-not-an-owner-of
git checkout -b eiennohi/engine-sprint/GiddyGiraffe.fix.dont-allow-commenting-on-activities-from-groups-youre-not-an-owner-of FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff eiennohi/engine-sprint/GiddyGiraffe.fix.dont-allow-commenting-on-activities-from-groups-youre-not-an-owner-of

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge eiennohi:sprint/GiddyGiraffe.fix.dont-allow-commenting-on-activities-from-groups-youre-not-an-owner-of into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #65200449 passed for 0cb2672a on eiennohi:sprint/GiddyGiraffe.fix.dont-allow-commenting-on-activities-from-groups-youre-not-an-owner-of
      Requires 2 more approvals from Devs.
      Martin Santangelo
      Martin Santangelo
      Mark Harding
      Mark Harding
      Ben Hayward
      Ben Hayward
      Rami Albatal
      Rami Albatal
      Emiliano Balbuena
      Emiliano Balbuena
      Ready to be merged automatically. Ask someone with write access to this repository to merge this request
      Allows commits from members who can merge to the target branch

      Closes front#1354

      Deletes source branch

      • Discussion 0
      • Commits 1
      • Pipelines 1
      • Changes 1
      • Loading...
      • Marcelo Rivera @eiennohi changed title from [Sprint/GiddyGiraffe] (fix): added acl:interact listener for group activities to [Sprint/GiddyGiraffe] (fix): banning does not stop users from commenting on group activities 2 hours ago

        changed title from [Sprint/GiddyGiraffe] (fix): added acl:interact listener for group activities to [Sprint/GiddyGiraffe] (fix): banning does not stop users from commenting on group activities

      • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
      Please register or sign in to reply
      Assignee
      None
      Assign to
      None
      Milestone
      None
      Assign milestone
      None
      Time tracking
      No estimate or time spent
      0
      Labels
      None
      Assign labels
      • View project labels
      Lock merge request
      Unlocked
      7
      7 participants
      user avatar
      Martin Santangelo
      user avatar
      Mark Harding
      user avatar
      Ben Hayward
      user avatar
      Rami Albatal
      user avatar
      Emiliano Balbuena
      user avatar
      Brian Hatchet
      user avatar
      Marcelo Rivera
      Reference: minds/engine!193