Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 143
    • Issues 143
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 33
    • Merge Requests 33
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !192

Open
Opened 6 hours ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/GiddyGiraffe] (fix): don't show suggestions if near subscriptions ratelimit threshold

closes #267

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/eiennohi/engine.git sprint/GiddyGiraffe.fix.dont-suggest-users-over-ratelimit-threshold
git checkout -b eiennohi/engine-sprint/GiddyGiraffe.fix.dont-suggest-users-over-ratelimit-threshold FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff eiennohi/engine-sprint/GiddyGiraffe.fix.dont-suggest-users-over-ratelimit-threshold

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge eiennohi:sprint/GiddyGiraffe.fix.dont-suggest-users-over-ratelimit-threshold into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #65025860 passed for baea3d0d on eiennohi:sprint/GiddyGiraffe.fix.dont-suggest-users-over-ratelimit-threshold
      Requires 2 more approvals from Devs.
      Ben Hayward
      Ben Hayward
      Rami Albatal
      Rami Albatal
      Mark Harding
      Mark Harding
      Emiliano Balbuena
      Emiliano Balbuena
      Brian Hatchet
      Brian Hatchet
      Ready to be merged automatically. Ask someone with write access to this repository to merge this request
      Allows commits from members who can merge to the target branch

      Closes #267

      Deletes source branch

      • Discussion 1
      • Commits 1
      • Pipelines 1
      • Changes 1
      • Loading...
      • Mark Harding
        Mark Harding @markeharding · 5 hours ago
        Owner

        Can this be moved to Manager with spec tests for safety?

      • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
      Please register or sign in to reply
      Assignee
      None
      Assign to
      None
      Milestone
      None
      Assign milestone
      None
      Time tracking
      No estimate or time spent
      0
      Labels
      None
      Assign labels
      • View project labels
      Lock merge request
      Unlocked
      7
      7 participants
      user avatar
      Ben Hayward
      user avatar
      Rami Albatal
      user avatar
      Mark Harding
      user avatar
      Emiliano Balbuena
      user avatar
      Brian Hatchet
      user avatar
      Martin Santangelo
      user avatar
      Marcelo Rivera
      Reference: minds/engine!192