Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 817
    • Issues 817
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 58
    • Merge Requests 58
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !337

Closed
Opened 5 hours ago by Olivia Madrid@omadrid
  • Report abuse
Report abuse

Clean up newsfeed poster UI

See issue #1383

(Note: Also made a couple additional minor adjustments outside of the poster component)

  • Removed redundant tooltip text on hashtag action button
  • Made paywall dropdown cursor pointer only in clickable space
  • removed white background color that was overflowing out of text input
  • changed Tokens to tokens in boost creator tooltip
  • replaced notifications tooltip with element title
  • made hashtag selector instructions text case consistent with other action buttons
  • fix topbar notifications/usermenu icon misalignment on window resize

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/omadrid/front.git newsfeedPosterUICleanup
git checkout -b omadrid/front-newsfeedPosterUICleanup FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff omadrid/front-newsfeedPosterUICleanup

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge omadrid:newsfeedPosterUICleanup into master
  • Email patches
  • Plain diff
Pipeline #65036108 passed for 654be2ec on omadrid:newsfeedPosterUICleanup
    Requires 2 more approvals from Devs.
    Ben Hayward
    Ben Hayward
    Marcelo Rivera
    Marcelo Rivera
    Mark Harding
    Mark Harding
    Emiliano Balbuena
    Emiliano Balbuena
    Brian Hatchet
    Brian Hatchet

    Closed by Olivia Madrid 4 hours ago

    The changes were not merged into master

    Mentions #1383

    Deletes source branch

    • Discussion 0
    • Commits 1
    • Pipelines 1
    • Changes 10
    • Loading...
    • Olivia Madrid @omadrid closed 4 hours ago

      closed

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    7
    7 participants
    user avatar
    Ben Hayward
    user avatar
    Marcelo Rivera
    user avatar
    Mark Harding
    user avatar
    Emiliano Balbuena
    user avatar
    Brian Hatchet
    user avatar
    Martin Santangelo
    user avatar
    Olivia Madrid
    Reference: minds/front!337