Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 808
    • Issues 808
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 55
    • Merge Requests 55
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !322

Closed
Opened 6 days ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/FunnyFrog](bug): Fixed toggle button hidden behind groups bar mobile. #1060

The toggle button was being hidden behind the groups bar; adjusting just the z-index didn't work so it needed to be re-positioned based upon its view.

image image

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git group-chat-navigation-fix-1060
git checkout -b benhayward.ben/front-group-chat-navigation-fix-1060 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-group-chat-navigation-fix-1060

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:group-chat-navigation-fix-1060 into master
  • Email patches
  • Plain diff
Pipeline #64831351 passed for 8d81d659 on benhayward.ben:group-chat-navigation-fix-1060
    Requires approval from Devs. Approved by
    Mark Harding
    Mark Harding
    Martin Santangelo
    Martin Santangelo
    Emiliano Balbuena
    Emiliano Balbuena
    Marcelo Rivera
    Marcelo Rivera
    Brian Hatchet
    Brian Hatchet

    Closed by Mark Harding 18 minutes ago

    The changes were not merged into master

    Allows commits from members who can merge to the target branch

    Mentions #1060 (closed)

    Deletes source branch

    • Discussion 3
    • Commits 5
    • Pipelines 5
    • Changes 2
    1/1 discussion resolved
    • Loading...
    • Mark Harding
      Mark Harding @markeharding started a discussion on an old version of the diff 6 days ago
      Resolved by Ben Hayward 6 days ago
    • Ben Hayward @benhayward.ben added 1 commit 6 days ago

      added 1 commit

      • 90e15742 - Update profile.component.scss

      Compare with previous version

    • Ben Hayward @benhayward.ben resolved all discussions 6 days ago

      resolved all discussions

    • Ben Hayward @benhayward.ben added 1 commit 6 days ago

      added 1 commit

      • e6751918 - Update profile.component.scss

      Compare with previous version

    • Ben Hayward @benhayward.ben added 1 commit 6 days ago

      added 1 commit

      • a67cca2f - Update profile.component.scss

      Compare with previous version

    • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 4 days ago

      approved this merge request

    • Mark Harding @markeharding added 1 commit 39 minutes ago

      added 1 commit

      • 8d81d659 - (fix): > 900px viewport rendered wrongly

      Compare with previous version

    • Mark Harding @markeharding approved this merge request 38 minutes ago

      approved this merge request

    • Mark Harding
      Mark Harding @markeharding · 38 minutes ago
      Owner

      @edgebal can you approve too?

    • Mark Harding @markeharding closed 18 minutes ago

      closed

    • Ben Hayward
      Ben Hayward @benhayward.ben · 5 minutes ago
      Developer

      @markeharding was this accidentally closed or has it been taken care of by you directly?

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Martin Santangelo
    user avatar
    Emiliano Balbuena
    user avatar
    Marcelo Rivera
    user avatar
    Brian Hatchet
    user avatar
    Ben Hayward
    user avatar
    Mark Harding
    Reference: minds/front!322