Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 141
    • Issues 141
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 29
    • Merge Requests 29
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !188

Merged
Opened 3 hours ago by Mark Harding@markeharding
  • Report abuse
Report abuse

(fix): attachments should use actions save

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b fix/NewsfeedAttachmentActionsSave origin/fix/NewsfeedAttachmentActionsSave

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff fix/NewsfeedAttachmentActionsSave

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge fix/NewsfeedAttachmentActionsSave into master
  • Email patches
  • Plain diff
Pipeline #64677410 passed for ea0c176a on fix/NewsfeedAttachmentActionsSave
      Merge request approved. Approved by
      Ben Hayward
      Ben Hayward
      Brian Hatchet
      Brian Hatchet
      Marcelo Rivera
      Marcelo Rivera
      Rami Albatal
      Rami Albatal
      Martin Santangelo
      Martin Santangelo
      Emiliano Balbuena
      Emiliano Balbuena

      Merged by Mark Harding 3 hours ago

      The changes were merged into master with c8faae41

      Pipeline #64678129 passed for c8faae41 on master
            • Discussion 0
            • Commits 1
            • Pipelines 1
            • Changes 1
            • Loading...
            • Brian Hatchet :speech_balloon: @brianhatchet approved this merge request 3 hours ago

              approved this merge request

            • Ben Hayward @benhayward.ben approved this merge request 3 hours ago

              approved this merge request

            • Ben Hayward @benhayward.ben mentioned in issue #489 (closed) 3 hours ago

              mentioned in issue #489 (closed)

            • Mark Harding @markeharding enabled an automatic merge when the pipeline for ea0c176a succeeds 3 hours ago

              enabled an automatic merge when the pipeline for ea0c176a succeeds

            • Mark Harding @markeharding merged 3 hours ago

              merged

            • Mark Harding @markeharding mentioned in commit c8faae41 3 hours ago

              mentioned in commit c8faae41

            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
            Please register or sign in to reply
            Assignee
            None
            Assign to
            None
            Milestone
            None
            Assign milestone
            None
            Time tracking
            No estimate or time spent
            0
            Labels
            None
            Assign labels
            • View project labels
            Lock merge request
            Unlocked
            7
            7 participants
            user avatar
            Marcelo Rivera
            user avatar
            Rami Albatal
            user avatar
            Martin Santangelo
            user avatar
            Emiliano Balbuena
            user avatar
            Mark Harding
            user avatar
            Ben Hayward
            user avatar
            Brian Hatchet
            Reference: minds/engine!188

            Revert this merge request

            This will create a new commit in order to revert the existing changes.

            Switch branch
            Cancel
            A new branch will be created in your fork and a new merge request will be started.

            Cherry-pick this merge request

            Switch branch
            Cancel
            A new branch will be created in your fork and a new merge request will be started.