Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 813
    • Issues 813
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 48
    • Merge Requests 48
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !325

Open
Opened 36 minutes ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/FunnyFrog] (fix): poor scrolling performance on mobile

closes #1346

Added CSS Grid to main page layout. As this makes m-body the scrollable container (vs the document), I needed to include refactors to infinite-scroll and GlobalScrollService.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/eiennohi/front.git sprint/FunnyFrog.fix.poor-performance-on-scroll-on-mobile
git checkout -b eiennohi/front-sprint/FunnyFrog.fix.poor-performance-on-scroll-on-mobile FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff eiennohi/front-sprint/FunnyFrog.fix.poor-performance-on-scroll-on-mobile

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge eiennohi:sprint/FunnyFrog.fix.poor-performance-on-scroll-on-mobile into master
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #64481796 failed for 0593bdfd on eiennohi:sprint/FunnyFrog.fix.poor-performance-on-scroll-on-mobile
    Requires 2 more approvals from Devs.
    Martin Santangelo
    Martin Santangelo
    Ben Hayward
    Ben Hayward
    Mark Harding
    Mark Harding
    Brian Hatchet
    Brian Hatchet
    Emiliano Balbuena
    Emiliano Balbuena
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request
    Allows commits from members who can merge to the target branch

    Closes #1346

    Deletes source branch

    • Discussion 0
    • Commits 3
    • Pipelines 1
    • Changes 61
    • Loading...
    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Martin Santangelo
    user avatar
    Ben Hayward
    user avatar
    Mark Harding
    user avatar
    Brian Hatchet
    user avatar
    Emiliano Balbuena
    user avatar
    Marcelo Rivera
    Reference: minds/front!325