Skip to content

Minds Backend - Engine
Minds Backend - Engine
Open
Opened by Ben Hayward@benhayward.ben
Report abuse

[Sprint/FunnyFrog](bug): Fixed bug that was stopping blocking from working #488

Closes #488

if (is_array($response['participants']) && false) {

meant that checking whether a user was blocked was never being attempted by the server - regardless the old code behind it no longer functioned, so I refactored it using

                    $blocked = Core\Security\ACL\Block::_()->isBlocked($participant['guid']);//check whether user is blocked

By my tests, this allows users to block bidirectionally (e.g. bob can block alice, then alice can block pop), and is respected when the window is reloaded.

Request to merge benhayward.ben:messenger-blocking-fix-488 into master
The source branch is 160 commits behind the target branch
Open in Web IDE
Pipeline #64479607 passed for 741b4f7c on benhayward.ben:messenger-blocking-fix-488
      Requires 2 more approvals from Devs.
      Ready to be merged automatically. Ask someone with write access to this repository to merge this request
      Allows commits from members who can merge to the target branch

      Closes #488

      Deletes source branch

      Please register or sign in to reply