Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 809
    • Issues 809
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 47
    • Merge Requests 47
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !322

Open
Opened 19 hours ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/FunnyFrog](bug): Fixed toggle button hidden behind groups bar mobile. #1060

The toggle button was being hidden behind the groups bar; adjusting just the z-index didn't work so it needed to be re-positioned based upon its view.

image image

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git group-chat-navigation-fix-1060
git checkout -b benhayward.ben/front-group-chat-navigation-fix-1060 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-group-chat-navigation-fix-1060

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:group-chat-navigation-fix-1060 into master
The source branch is 4 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #63944458 passed for a67cca2f on benhayward.ben:group-chat-navigation-fix-1060
    Requires 2 more approvals from Devs.
    Emiliano Balbuena
    Emiliano Balbuena
    Marcelo Rivera
    Marcelo Rivera
    Mark Harding
    Mark Harding
    Martin Santangelo
    Martin Santangelo
    Brian Hatchet
    Brian Hatchet
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request
    Allows commits from members who can merge to the target branch

    Mentions #1060

    Deletes source branch

    • Discussion 1
    • Commits 4
    • Pipelines 4
    • Changes 2
    1/1 discussion resolved
    • Loading...
    • Mark Harding
      Mark Harding @markeharding started a discussion on an old version of the diff 2 hours ago
      Resolved by Ben Hayward 2 hours ago
    • Ben Hayward @benhayward.ben added 1 commit 2 hours ago

      added 1 commit

      • 90e15742 - Update profile.component.scss

      Compare with previous version

    • Ben Hayward @benhayward.ben resolved all discussions 2 hours ago

      resolved all discussions

    • Ben Hayward @benhayward.ben added 1 commit 2 hours ago

      added 1 commit

      • e6751918 - Update profile.component.scss

      Compare with previous version

    • Ben Hayward @benhayward.ben added 1 commit 2 hours ago

      added 1 commit

      • a67cca2f - Update profile.component.scss

      Compare with previous version

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Emiliano Balbuena
    user avatar
    Marcelo Rivera
    user avatar
    Mark Harding
    user avatar
    Martin Santangelo
    user avatar
    Brian Hatchet
    user avatar
    Ben Hayward
    Reference: minds/front!322