Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 809
    • Issues 809
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 47
    • Merge Requests 47
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !321

Open
Opened 21 hours ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/FunnyFrog](bug): Added in counter for comments and alert. #452

Closing #452

I decided rather than throwing an alert at the user, it'd be better to let them write or paste in what they want, and then cut it down to the appropriate length.

Counter is hidden if comment is empty as normal.

image

Without the error bar.

image

With the error bar.

image

image

image

Edited 21 hours ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git comment-length-indicator-and-error-452
git checkout -b benhayward.ben/front-comment-length-indicator-and-error-452 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-comment-length-indicator-and-error-452

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:comment-length-indicator-and-error-452 into master
The source branch is 6 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #63959120 passed for 1829ba73 on benhayward.ben:comment-length-indicator-and-error-452
    Requires 2 more approvals from Devs.
    Mark Harding
    Mark Harding
    Emiliano Balbuena
    Emiliano Balbuena
    Marcelo Rivera
    Marcelo Rivera
    Martin Santangelo
    Martin Santangelo
    Brian Hatchet
    Brian Hatchet
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request
    Allows commits from members who can merge to the target branch

    Closes #452

    Deletes source branch

    • Discussion 5
    • Commits 3
    • Pipelines 3
    • Changes 3
    2/3 discussions resolved
    • Loading...
    • Ben Hayward @benhayward.ben changed the description 21 hours ago

      changed the description

    • Mark Harding
      Mark Harding @markeharding started a discussion on an old version of the diff 2 hours ago
      Resolved by Ben Hayward 26 minutes ago
    • Mark Harding
      Mark Harding @markeharding started a discussion on the diff 2 hours ago
      Last updated by Ben Hayward 24 minutes ago
      src/app/modules/comments/poster/poster.component.html
      8 13 </div>
      9 14
      10 15 <div class="minds-body">
      11
      12 16 <div class="m-comments-composer">
      17
      13 18 <form (submit)="post($event)">
      14 19 <minds-textarea
      15 20 #message="Textarea"
      16 21 [(mModel)]="content"
      17 22 [disabled]="(ascendingInProgress || descendingInProgress) && attachment.hasFile()"
      18 (keyup)="getPostPreview(content)"
      23 (keyup)="getPostPreview(content); characterCount(content)"
      • Mark Harding
        Mark Harding @markeharding · 2 hours ago
        Owner

        dont think we need this?

      • Ben Hayward
        Ben Hayward @benhayward.ben · 24 minutes ago
        Developer

        I think we do (and have tested), else there is nothing detecting on a key being pressed, only on paste and backspace

      Please register or sign in to reply
    • Mark Harding
      Mark Harding @markeharding started a discussion on an old version of the diff 2 hours ago
      Resolved by Ben Hayward 26 minutes ago
    • Ben Hayward @benhayward.ben added 1 commit 32 minutes ago

      added 1 commit

      • 40a70b69 - small refactor and css name change

      Compare with previous version

    • Ben Hayward @benhayward.ben added 1 commit 27 minutes ago

      added 1 commit

      • 1829ba73 - adding theming

      Compare with previous version

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Emiliano Balbuena
    user avatar
    Marcelo Rivera
    user avatar
    Mark Harding
    user avatar
    Martin Santangelo
    user avatar
    Brian Hatchet
    user avatar
    Ben Hayward
    Reference: minds/front!321