Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 809
    • Issues 809
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 47
    • Merge Requests 47
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !321

Open
Opened 20 hours ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/FunnyFrog](bug): Added in counter for comments and alert. #452

Closing #452

I decided rather than throwing an alert at the user, it'd be better to let them write or paste in what they want, and then cut it down to the appropriate length.

Counter is hidden if comment is empty as normal.

image

Without the error bar.

image

With the error bar.

image

image

image

Edited 20 hours ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git comment-length-indicator-and-error-452
git checkout -b benhayward.ben/front-comment-length-indicator-and-error-452 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-comment-length-indicator-and-error-452

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:comment-length-indicator-and-error-452 into master
The source branch is 6 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #63808687 passed for 6f978217 on benhayward.ben:comment-length-indicator-and-error-452
    Requires 2 more approvals from Devs.
    Emiliano Balbuena
    Emiliano Balbuena
    Brian Hatchet
    Brian Hatchet
    Marcelo Rivera
    Marcelo Rivera
    Mark Harding
    Mark Harding
    Martin Santangelo
    Martin Santangelo
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request
    Allows commits from members who can merge to the target branch

    Closes #452

    Deletes source branch

    • Discussion 4
    • Commits 1
    • Pipelines 1
    • Changes 3
    0/3 discussions resolved
    • Loading...
    • Ben Hayward @benhayward.ben changed the description 20 hours ago

      changed the description

    • Mark Harding
      Mark Harding @markeharding started a discussion on the diff 1 hour ago
      Last updated by Mark Harding 1 hour ago
      src/app/modules/comments/poster/poster.component.html
      1
      1 <div>
      2 <div [class.hidden]="!error" class="mdl-card mdl-color--red-500 mdl-color-text--blue-grey-50 mdl-shadow--2dp">
      3 <span class="mdl-card__supporting-text mdl-color-text--blue-grey-50" style="text-align: center;">{{error}}</span>
      4 </div>
      5 </div>
      6 <span [class.hidden]="charCount === 0" class="m-comment-composer-charCount">{{charCount}} / 1500</span>
      • Mark Harding
        Mark Harding @markeharding · 1 hour ago
        Owner

        why not just use content.length?

      • Mark Harding
        Mark Harding @markeharding · 1 hour ago
        Owner

        for class name use m-commentPoster__limit

      Please register or sign in to reply
    • Mark Harding
      Mark Harding @markeharding started a discussion on the diff 1 hour ago
      src/app/modules/comments/poster/poster.component.html
      8 13 </div>
      9 14
      10 15 <div class="minds-body">
      11
      12 16 <div class="m-comments-composer">
      17
      13 18 <form (submit)="post($event)">
      14 19 <minds-textarea
      15 20 #message="Textarea"
      16 21 [(mModel)]="content"
      17 22 [disabled]="(ascendingInProgress || descendingInProgress) && attachment.hasFile()"
      18 (keyup)="getPostPreview(content)"
      23 (keyup)="getPostPreview(content); characterCount(content)"
      • Mark Harding
        Mark Harding @markeharding · 1 hour ago
        Owner

        dont think we need this?

      Please register or sign in to reply
    • Mark Harding
      Mark Harding @markeharding started a discussion on the diff 1 hour ago
      src/app/modules/comments/poster/poster.component.scss
      1 .m-comment-composer-charCount {
      2 font-size: 10px;
      3 color: #666;
      • Mark Harding
        Mark Harding @markeharding · 1 hour ago
        Owner

        please use global colours

      Please register or sign in to reply
    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Emiliano Balbuena
    user avatar
    Brian Hatchet
    user avatar
    Marcelo Rivera
    user avatar
    Mark Harding
    user avatar
    Martin Santangelo
    user avatar
    Ben Hayward
    Reference: minds/front!321