Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 800
    • Issues 800
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 44
    • Merge Requests 44
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !317

Merged
Opened 32 minutes ago by Brian Hatchet@brianhatchet:speech_balloon:
  • Report abuse
Report abuse

(fix) Fixing wire creator offchain

Missed checking the payload so we don't prompt for metamask during offchain wires

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/brianhatchet/front.git fixing-wire-creator-offchain
git checkout -b brianhatchet/front-fixing-wire-creator-offchain FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff brianhatchet/front-fixing-wire-creator-offchain

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge brianhatchet:fixing-wire-creator-offchain into master
  • Email patches
  • Plain diff
Pipeline #63070290 passed for 7dbc3f51 on brianhatchet:fixing-wire-creator-offchain
    Merge request approved. Approved by
    Ben Hayward
    Ben Hayward
    Mark Harding
    Mark Harding
    Martin Santangelo
    Martin Santangelo
    Marcelo Rivera
    Marcelo Rivera
    Emiliano Balbuena
    Emiliano Balbuena

    Merged by Mark Harding 22 minutes ago

    The changes were merged into master with d5b84390

    Pipeline #63071865 running for d5b84390 on master
          • Discussion 0
          • Commits 7
          • Pipelines 1
          • Changes 1
          • Loading...
          • Mark Harding @markeharding approved this merge request 27 minutes ago

            approved this merge request

          • Ben Hayward @benhayward.ben approved this merge request 23 minutes ago

            approved this merge request

          • Mark Harding @markeharding merged 22 minutes ago

            merged

          • Mark Harding @markeharding mentioned in commit d5b84390 22 minutes ago

            mentioned in commit d5b84390

          • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
          Please register or sign in to reply
          Assignee
          None
          Assign to
          None
          Milestone
          None
          Assign milestone
          None
          Time tracking
          No estimate or time spent
          0
          Labels
          None
          Assign labels
          • View project labels
          Lock merge request
          Unlocked
          6
          6 participants
          user avatar
          Martin Santangelo
          user avatar
          Marcelo Rivera
          user avatar
          Emiliano Balbuena
          user avatar
          Mark Harding
          user avatar
          Ben Hayward
          user avatar
          Brian Hatchet
          Reference: minds/front!317

          Revert this merge request

          This will create a new commit in order to revert the existing changes.

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.

          Cherry-pick this merge request

          Switch branch
          Cancel
          A new branch will be created in your fork and a new merge request will be started.