Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 800
    • Issues 800
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 44
    • Merge Requests 44
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !264

Closed
Opened 1 month ago by Marcelo Rivera@eiennohi
  • Report abuse
Report abuse

[Sprint/BoisterousBuffalo] (fix): comment bubble for blogs gets cut off on mobile resolutions

closes #1124 (closed)

Just FYI, I tested this for a while in different sections of the site and I didn't see any glitches from removing min-height in m-body.

Edited 1 month ago by Marcelo Rivera

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/eiennohi/front.git sprint/BoisterousBuffalo.fix.comment-bubble-for-blogs-gets-cut-off-on-mobile-resolutions
git checkout -b eiennohi/front-sprint/BoisterousBuffalo.fix.comment-bubble-for-blogs-gets-cut-off-on-mobile-resolutions FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff eiennohi/front-sprint/BoisterousBuffalo.fix.comment-bubble-for-blogs-gets-cut-off-on-mobile-resolutions

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge eiennohi:sprint/BoisterousBuffalo.fix.comment-bubble-for-blogs-gets-cut-off-on-mobile-resolutions into master
  • Email patches
  • Plain diff
Pipeline #57823769 passed for a4f1385e on eiennohi:sprint/BoisterousBuffalo.fix.comment-bubble-for-blogs-gets-cut-off-on-mobile-resolutions
    Requires 2 more approvals.

    Closed by Mark Harding 2 hours ago

    The changes were not merged into master

    Allows commits from members who can merge to the target branch

    Did not close #1124 (closed)

    Deletes source branch

    • Discussion 2
    • Commits 1
    • Pipelines 1
    • Changes 2
    • Loading...
    • Marcelo Rivera @eiennohi changed the description 1 month ago

      changed the description

    • Mark Harding
      Mark Harding @markeharding · 4 weeks ago
      Owner

      min-height: 100% is used to prevent the following issues with the background cutting off Screen_Shot_2019-04-24_at_11.16.56

    • Marcelo Rivera
      Marcelo Rivera @eiennohi · 4 weeks ago
      Developer

      @markeharding what about setting background-color: #f8f8f8; to body vs m-body?

    • Mark Harding @markeharding closed 2 hours ago

      closed

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    2
    2 participants
    user avatar
    Mark Harding
    user avatar
    Marcelo Rivera
    Reference: minds/front!264