Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 800
    • Issues 800
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 44
    • Merge Requests 44
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !267

Open
Opened 1 month ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/BoisterousBuffalo](bug): Fixing alignment of tooltips on mobile web #1058

image-881b2637-08b1-4359-b90b-ea011c08ba35

Apologies for bad quality image - made it so tooltip on mobile lines up with the bottom of its container instead of over the container. Could move this down further with transform translate but think that it looks fine where it is. Let me know, quick change.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git group-topbar-tooltip-align-mobile-web2
git checkout -b benhayward.ben/front-group-topbar-tooltip-align-mobile-web2 FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-group-topbar-tooltip-align-mobile-web2

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:group-topbar-tooltip-align-mobile-web2 into master
The source branch is 141 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #62437436 passed for a78eea7c on benhayward.ben:group-topbar-tooltip-align-mobile-web2
    Requires 2 more approvals.
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request
    Allows commits from members who can merge to the target branch

    Mentions #1058

    Deletes source branch

    • Discussion 6
    • Commits 5
    • Pipelines 5
    • Changes 1
    1/2 discussions resolved
    • Loading...
    • Mark Harding
      Mark Harding @markeharding started a discussion on an old version of the diff 4 weeks ago
      Resolved by Ben Hayward 1 week ago
    • Ben Hayward @benhayward.ben added 1 commit 4 weeks ago

      added 1 commit

      • c26d8a0d - Simplified CSS

      Compare with previous version

    • Ben Hayward @benhayward.ben added 1 commit 3 weeks ago

      added 1 commit

      • 43434ae5 - Update sidebar-markers.component.scss

      Compare with previous version

    • Ben Hayward @benhayward.ben resolved all discussions 1 week ago

      resolved all discussions

    • Mark Harding
      Mark Harding @markeharding · 2 days ago
      Owner

      Please revisit

    • Ben Hayward
      Ben Hayward @benhayward.ben · 2 days ago
      Developer

      Wrap it in a media query - note to self

    • Ben Hayward @benhayward.ben added 1 commit 2 days ago

      added 1 commit

      • 8bef3937 - wrapped margin top on media query for mobile

      Compare with previous version

    • Ben Hayward
      Ben Hayward @benhayward.ben · 2 days ago
      Developer

      Amended

    • Ben Hayward @benhayward.ben added 1 commit 2 days ago

      added 1 commit

      • a78eea7c - Update sidebar-markers.component.scss

      Compare with previous version

    • Mark Harding
      Mark Harding @markeharding started a discussion on the diff 29 minutes ago
      src/app/modules/groups/sidebar-markers/sidebar-markers.component.scss
      160 160 }
      161 161
      162 162 .m-tooltip--bubble--anchor-right {
      163 margin-top: -36px;
      • Mark Harding
        Mark Harding @markeharding · 29 minutes ago
        Owner

        Why is this being removed?

      Please register or sign in to reply
    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    None
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    2
    2 participants
    user avatar
    Mark Harding
    user avatar
    Ben Hayward
    Reference: minds/front!267