Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 129
    • Issues 129
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 28
    • Merge Requests 28
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !178

Merged
Opened 9 hours ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/FunnyFrog])(bug): Forcing NSFW reasons array into integers.

Closing minds#428 (closed)

It appears that the array holding NSFW reasons, for reminds was being passed to the front-end as a string, which was causing a quiet error in JS. Below is examples of both post types working with the changes proposed by @markeharding

image image

Edited 8 hours ago by Ben Hayward
Request to merge benhayward.ben:fix-nsfw-remind-inheritance-bug into master
  • Email patches
  • Plain diff
Pipeline #62854068 passed for d76b3ea4 on benhayward.ben:fix-nsfw-remind-inheritance-bug
      Merge request approved. Approved by
      Mark Harding
      Mark Harding

      Merged by Mark Harding 6 hours ago

      The changes were merged into master with fcfd028f

      The source branch has been deleted

      Allows commits from members who can merge to the target branch

      Closed minds#428 (closed)

      Pipeline #62865832 passed for fcfd028f on master
            • Discussion 0
            • Commits 2
            • Pipelines 2
            • Changes 1
            • Loading...
            • Ben Hayward @benhayward.ben changed the description 8 hours ago

              changed the description

            • Ben Hayward @benhayward.ben added 1 commit 8 hours ago

              added 1 commit

              • d76b3ea4 - Updated to account for a null array

              Compare with previous version

            • Mark Harding @markeharding approved this merge request 6 hours ago

              approved this merge request

            • Mark Harding @markeharding merged 6 hours ago

              merged

            • Mark Harding @markeharding mentioned in commit fcfd028f 6 hours ago

              mentioned in commit fcfd028f

            • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
            Please register or sign in to reply
            2 Assignees
            Marcelo Rivera's avatar
            Emiliano Balbuena's avatar
            Assign to
            None
            Milestone
            None
            Assign milestone
            None
            Time tracking
            No estimate or time spent
            0
            Labels
            None
            Assign labels
            • View project labels
            Lock merge request
            Unlocked
            4
            4 participants
            user avatar
            Marcelo Rivera
            user avatar
            Emiliano Balbuena
            user avatar
            Mark Harding
            user avatar
            Ben Hayward
            Reference: minds/engine!178

            Revert this merge request

            This will create a new commit in order to revert the existing changes.

            Switch branch
            Cancel
            A new branch will be created in your fork and a new merge request will be started.

            Cherry-pick this merge request

            Switch branch
            Cancel
            A new branch will be created in your fork and a new merge request will be started.