Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 802
    • Issues 802
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 48
    • Merge Requests 48
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !304

Open
Opened 1 week ago by Brian Hatchet@brianhatchet:speech_balloon:
  • Report abuse
Report abuse

Metamask buy token modal

Added a new GetMetamaskComponent which splices into the transaction overlay flow

Before we display the "Provide your private" key dialog, the Wire and Boost creator components check to see if the wallet is local. If it is local, then we provide the prompt to download metamask.

There's two links on the component. Clicking "create" will route the user to the wallet page. Clicking "provide" will take them to the old provide screen

Edited 1 day ago by Brian Hatchet

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/brianhatchet/front.git metamask-buy-token-modal
git checkout -b brianhatchet/front-metamask-buy-token-modal FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/epic/onchainImprovements
git merge --no-ff brianhatchet/front-metamask-buy-token-modal

Step 4. Push the result of the merge to GitLab

git push origin epic/onchainImprovements

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge brianhatchet:metamask-buy-token-modal into epic/onchainImprovements
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #62856632 failed for 415b8fe4 on brianhatchet:metamask-buy-token-modal
    Requires 2 more approvals from Developers.
    Marcelo Rivera
    Marcelo Rivera
    Martin Santangelo
    Martin Santangelo
    Emiliano Balbuena
    Emiliano Balbuena
    Mark Harding
    Mark Harding
    Ben Hayward
    Ben Hayward
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request
    Allows commits from members who can merge to the target branch

    Deletes source branch

    • Discussion 1
    • Commits 6
    • Pipelines 6
    • Changes 17
    • Loading...
    • Mark Harding @markeharding changed target branch from master to epic/onchainImprovements 1 week ago

      changed target branch from master to epic/onchainImprovements

    • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 1 day ago

      added 1 commit

      • ab5235f3 - (feature) Metamask download prompts in our transaction overlays

      Compare with previous version

    • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 1 day ago

      added 1 commit

      • b5898424 - Fixing the pre-existing tests except for hashtags

      Compare with previous version

    • Brian Hatchet :speech_balloon: @brianhatchet added 1 commit 1 day ago

      added 1 commit

      • f649d318 - Unit tests for the get metamask component

      Compare with previous version

    • Brian Hatchet :speech_balloon: @brianhatchet unmarked as a Work In Progress 1 day ago

      unmarked as a Work In Progress

    • Brian Hatchet :speech_balloon: @brianhatchet changed the description 1 day ago

      changed the description

    • Brian Hatchet :speech_balloon: @brianhatchet changed milestone to %sprint: Funny Frog 1 day ago

      changed milestone to %sprint: Funny Frog

    • Brian Hatchet :speech_balloon: @brianhatchet assigned to @brianhatchet 1 day ago

      assigned to @brianhatchet

    • Mark Harding @markeharding added 1 commit 4 hours ago

      added 1 commit

      • 27287615 - (chore): do not use export default at this trips up aot

      Compare with previous version

    • Ben Hayward
      Ben Hayward @benhayward.ben · 2 hours ago
      Developer

      Happy to review and test locally but the above build is failing.

    • Brian Hatchet :speech_balloon: @brianhatchet added 2 commits 1 hour ago

      added 2 commits

      • 639a433e - 1 commit from branch minds:epic/onchainImprovements
      • 415b8fe4 - Merge branch 'epic/onchainImprovements' of gitlab.com:minds/front into metamask-buy-token-modal

      Compare with previous version

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    Brian Hatchet's avatar Brian Hatchet @brianhatchet
    Assign to
    sprint: Funny Frog
    Milestone
    sprint: Funny Frog
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    6
    6 participants
    user avatar
    Marcelo Rivera
    user avatar
    Martin Santangelo
    user avatar
    Emiliano Balbuena
    user avatar
    Mark Harding
    user avatar
    Ben Hayward
    user avatar
    Brian Hatchet
    Reference: minds/front!304