Skip to content

Minds Frontend
Minds Frontend
Closed
Opened by Ben Hayward@benhayward.ben
Report abuse

WIP: [Sprint/FunnyFrog](bug): Fixed bugs with reminds not respecting NSFW state of a post

Closing minds#428

Take the below code.

let object = { nsfw : [1, 2, 3, 4] };
let res = [ 1, 2, 4 ].filter(nsfw => { return object.nsfw.indexOf(nsfw) > -1}).length;
console.log(res);

It should output the integer 3. Unfortunately for some reason, when considering reminds it does not, it outputs 0.

Given the input parameters seem the same, I'm thinking that it is some strange quirk of Javascript, or an issue with types. I got some strange behavior trying to Array.from(object.nsfw) so perhaps it needs casting.

Resuming tomorrow.

Edited by Ben Hayward
Request to merge benhayward.ben:nsfw-broken-for-reminds-#428 into master
Pipeline #62694871 passed for d05de6c4 on benhayward.ben:nsfw-broken-for-reminds-#428
    Requires 2 more approvals from Devs.

    Closed by Ben Hayward

    The changes were not merged into master

    Allows commits from members who can merge to the target branch

    Did not close minds#428

    Deletes source branch

    Please register or sign in to reply