Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Minds Backend - Engine
Minds Backend - Engine
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 127
    • Issues 127
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 28
    • Merge Requests 28
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds Backend - EngineMinds Backend - Engine
  • Merge Requests
  • !178

Open
Opened 15 minutes ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/FunnyFrog])(bug): Forcing NSFW reasons array into integers.

Closing minds#428

It appears that the array holding NSFW reasons, for reminds was being passed to the front-end as a string, which was causing a quiet error in JS. Below is examples of both post types working with the changes proposed by @markeharding

image image

Edited 7 minutes ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/engine.git fix-nsfw-remind-inheritance-bug
git checkout -b benhayward.ben/engine-fix-nsfw-remind-inheritance-bug FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/engine-fix-nsfw-remind-inheritance-bug

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:fix-nsfw-remind-inheritance-bug into master
The source branch is 122 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #62841431 passed for e0015a06 on benhayward.ben:fix-nsfw-remind-inheritance-bug
      Merge request approved.
      Ready to be merged automatically. Ask someone with write access to this repository to merge this request
      Allows commits from members who can merge to the target branch

      Closes minds#428

      Deletes source branch

      • Discussion 0
      • Commits 1
      • Pipelines 1
      • Changes 1
      • Loading...
      • Ben Hayward @benhayward.ben changed the description 7 minutes ago

        changed the description

      • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
      Please register or sign in to reply
      2 Assignees
      Marcelo Rivera's avatar
      Emiliano Balbuena's avatar
      Assign to
      None
      Milestone
      None
      Assign milestone
      None
      Time tracking
      No estimate or time spent
      0
      Labels
      None
      Assign labels
      • View project labels
      Lock merge request
      Unlocked
      4
      4 participants
      user avatar
      Marcelo Rivera
      user avatar
      Emiliano Balbuena
      user avatar
      Ben Hayward
      user avatar
      Mark Harding
      Reference: minds/engine!178