Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
Minds Frontend
Minds Frontend
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 820
    • Issues 820
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 50
    • Merge Requests 50
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Packages
    • Packages
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Minds
  • Minds FrontendMinds Frontend
  • Merge Requests
  • !280

Open
Opened 4 hours ago by Ben Hayward@benhayward.ben
  • Report abuse
Report abuse

[Sprint/CleverChipmunk](bug): Adding in auto-complete username & password

This actually does NOT fix minds#297. Had a good play with it and cannot work out what is going on - the browser should recognise that the autocomplete="username" field should not contain a password, but it doesn't, unless you click down in the password field and then it fills out normally.

I would recommend to the user in question to use a password manager like KeePass, or if less bothered about Open Source, 1Password / LastPass, as storing your passwords in browser is quite an insecure practice in my opinion.

Works fine with 1Password which I've tested, already did, but added these because they're considered good practice to have in login forms.

Edited 4 hours ago by Ben Hayward

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/benhayward.ben/front.git autocomplete-properties-added-login-form
git checkout -b benhayward.ben/front-autocomplete-properties-added-login-form FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff benhayward.ben/front-autocomplete-properties-added-login-form

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Request to merge benhayward.ben:autocomplete-properties-added-login-form into master
The source branch is 8 commits behind the target branch
Open in Web IDE
  • Email patches
  • Plain diff
Pipeline #58659545 passed for 434f5fb9 on benhayward.ben:autocomplete-properties-added-login-form
    No approval required
    Ready to be merged automatically. Ask someone with write access to this repository to merge this request
    Allows commits from members who can merge to the target branch

    Closes minds#297

    Deletes source branch

    • Discussion 0
    • Commits 1
    • Pipelines 1
    • Changes 1
    • Loading...
    • Ben Hayward @benhayward.ben changed title from Sprint/CleverChipmunk: Adding in auto-complete username & password{- #297 (closed)-} to Sprint/CleverChipmunk: Adding in auto-complete username & password 4 hours ago

      changed title from Sprint/CleverChipmunk: Adding in auto-complete username & password{- #297 (closed)-} to Sprint/CleverChipmunk: Adding in auto-complete username & password

    • Ben Hayward @benhayward.ben changed the description 4 hours ago

      changed the description

    • You're only seeing other activity in the feed. To add a comment, switch to one of the following options.
    Please register or sign in to reply
    Assignee
    No assignee
    Assign to
    None
    Milestone
    None
    Assign milestone
    None
    Time tracking
    No estimate or time spent
    0
    Labels
    None
    Assign labels
    • View project labels
    Lock merge request
    Unlocked
    1
    1 participant
    user avatar
    Ben Hayward
    Reference: minds/front!280