Facebook Login popup not big enough

angelim (Alexandre Angelim) 2014-03-24 04:31:41 UTC #1

I'm getting the following message when trying to register with facebook:

Your popup is too small to display this page. Please enlarge it to proceed.

Changing the height to 420px in jsapp/controllers/login_controller.js:96 solves the problem, but I didn't test on a phone or anything.

Thank you

riking (Kane York) 2014-03-24 05:00:49 UTC #2

Sent a PR: https://github.com/discourse/discourse/pull/2167

EDIT: Wait, the facebook auth is working fine for me right now:

angelim (Alexandre Angelim) 2014-03-24 06:17:05 UTC #3

The page I'm talking about is the one you grant permissions. I've already attached an image as a comment on your pull request at Github. Here it is again:

codinghorror (Jeff Atwood) 2014-04-13 19:45:36 UTC #4

Thanks, this was fixed!

codinghorror (Jeff Atwood) 2014-04-13 19:45:46 UTC #5