Hacker Newsnew | comments | show | ask | jobs | submitlogin
Lenovo Caught Installing Adware on New Computers (thenextweb.com)
337 points by cpeterso 2 hours ago | 133 comments





This is much worse than just installing adware. They install a web proxy which MITMs all web connections, including HTTPS by means of a pre-installed trusted root certificate.

The root certificate is the same across all installs, and the private key is present on the machine (necessarily, to operate the proxy): https://twitter.com/fugueish/status/568258997578371072

Someone will extract the private key in the next few hours, and then HTTPS will be basically completely broken for all Lenovo users -- anyone will be able to spoof any site to them.

Uninstalling the app does NOT remove the certificate: https://twitter.com/metsfan/status/568265468173107200

On the bright side, Firefox does not use the system certificates (it has its own list) and Chrome will no doubt push an update to block the certificate promptly.

reply


I'm curious what legal stance Lenovo customers have here - their secure HTTPS connections are being MITMed intentionally - surely that's hacking, or some national security violation?

reply


It's a big company doing, so it's gonna be fine.

reply


It certainly seems like unauthorised use of a computer system, on the face of it.

reply


> their secure HTTPS connections are being MITMed intentionally

of course they are - Lenovo customers have signed the agreement that this is ok when they started the machine the first time </sarcasm>

reply


Remaining questions: Does the superfish proxy itself check the certificate of the site it's connecting to? One would hope, but that's also a pretty easy thing to screw up.

If it does, does it trust its own cert? Probably (certainly?), but if not, that would leave one in the curious (perverse?) position of being safer by using the proxy. superfish can mitm your connection, but nobody else with the key could.

reply


Wow, there are tons of images on twitter about this [1]. There is one where they MITM https://www.bankofamerica.com/ too [2]. Why the hell would they do this. Brutal.

[1] https://twitter.com/search?q=%23superfish&src=typd

[2] https://twitter.com/kennwhite/status/568270748638318593/phot...

reply


I assume it's easier to MITM everything.

reply


Mozilla discussion about what to do with the Superfish cert:

Bug 1134506 - Mark "Superfish, Inc." root certificate as untrusted in NSS

https://bugzilla.mozilla.org/show_bug.cgi?id=1134506

reply


While it is akin to playing whack-a-mole, it's nice to see them seriously considering blocking this cert so users who get a theoretical update in Firefox would have it simply be removed. Granted Superfish could update and get around it but that would require effort and considering the PR nightmare Lenovo is going to be fielding I doubt they would do so.

reply


Yea, this should get into the news which will hopefully help a lot.

reply


Here's Lenovo trying to justify the presence of this software, naturally oblivious to the security implications:

https://forums.lenovo.com/t5/Lenovo-P-Y-and-Z-series/Lenovo-...

reply


notice how they focus 3/4 paragrahps on "the technology"

-----


naturally oblivious to the security implications

Rest assured Lenovo was perfectly aware of the security and privacy implications of this feature from the beginning.

They merely try to sound oblivious because their laywers hope that will soften the legal and media repercussions.

reply


Honestly, I think that's unlikely. This is far too sloppy to have been intentional. There are much better ways to implement a backdoor when you control the OS image. This is just incompetence, plain and simple.

Superfish looks like the kind of crapware that pays OEMs to include it in their bundle. Lenovo took the cash and didn't bother to review the code. Superfish, for its part, probably doesn't have the best and brightest engineers working for them. They probably tasked a junior programmer with working around SSL, who then committed the first solution that worked without ever thinking about security implications, and they shipped it.

reply


Cannot see how this could possibly be true. Having been privy to OS bundling for products, I can assure you there is lengthy contracts, and negotiations, about exactly what is happening. You do no simply walk up to Lenovo and have your "software" installed into the OS without a very detailed contract and pay structure. There also looks to be js injected into pages, which is serving up the ads, and a comment about Lenovo [1]. Think about what the means. There was a project at this company, where they had meetings, project plans, testing to make sure it worked, and a very detailed idea of what was going on. Never mind all the ramping up capacity due to new Lenovo's boxes coming on-line. There is zero chance this was some low level junior programmer fly by night operation.

[1] https://news.ycombinator.com/item?id=9072542

reply


Oh I'm sure they had lots of meetings about the contracts and pay structure, and they may have done testing to make sure it didn't break things, but apparently no one did a security review. Sadly, this doesn't surprise me that much.

If they did know about the problem, they could have fixed it. If the app simply generated a new key as part of first-time use, then it would just be run-of-the-mill crapware rather than a gaping security hole. Even if Lenovo has malicious intent, it would still have been in their best interests to do at least that, yet they didn't. Hence I assume it was incompetence.

reply


but apparently no one did a security review

It doesn't take a "security review" to spot a gaping security and privacy violation like this.

Any engineer with even the slightest clue of how a browser and "the internet" works would have called this out during the first "How does this product work?"-presentation.

Let's not pretend Lenovo is staffed with monkeys.

reply


“Never ascribe to malice that which can adequately be explained by incompetence.”

Remember stuff like this:

http://www.cryptofails.com/post/70059600123/saltstack-rsa-e-...

(Which, possibly unfairly, is one reason I'm leaning more towards ansible than saltstack to this day -- I mean, if stuff like that got through... what else, in more complex areas of the system?)

reply


You're so optimistic it hurts

"Any engineer" means something in HN, but we're not talking about "people who read HN" levels of engineer here, don't be mistaken.

Some people that have had no or limited experience with software are assigned to software projects, and that's the issue with companies like Lenovo.

reply


I don't know, I've worked on some large government projects where things like this could have possibly slipped through because an engineer or two thought it was a clever way to workaround the issue. Granted they should have known and may have known but I'm not convinced they had to have known.

reply


Interesting this appears to only be on the consumer grade laptops. I know at first glance I saw nothing relating to it on my W540 that I bought in November.

reply


The certificate technique they use dates back to at least 2010 (possibly only in add-on form back then?) See https://groups.google.com/forum/m/#!topic/mozilla.support.fi... for example. This causes other problems too: http://www.id.ee/index.php?id=37046 It's not alone in this behavior: http://kb.mit.edu/confluence/display/istcontrib/Programs+tha...

reply


What's funny is that they have three apps for photo-based matching of products...and pets. They really are a "visual search" company, a CA start-up of 80-200 people according to LinkedIn... They just seem to have forgotten the "don't be evil" parts of their business model...

reply


> They just seem to have forgotten the "don't be evil" parts of their business model...

That or maybe they are completely clueless about the security implications.

reply


I think you mean "do no evil"? https://news.ycombinator.com/item?id=9013374

reply


Anyway to see if that certificate is on a Lenovo computer? Anyway to remove it? I bought a Lenovo laptop recently, and I was appalled at the amount of crapware that was installed. It's a wonderful laptop at a great price, just too bad about the software.

reply


> It's a wonderful laptop at a great price, just too bad about the software.

Lenovo's hardware support for Linux is great so unless there's something keeping you on Windows switching to a good Linux distro usually works fine on these laptops.

reply


It should show up in the system certificates list as "Superfish, Inc.". I haven't seen it myself but search for #superfish on Twitter to see a lot of screenshots and such.

reply


Check Certificate Management in mmc.exe (Add Snap-In).

reply


Or just run certmgr.msc.

-----


I'm confused; if Firefox doesn't use the system certificates, shouldn't Firefox users have been seeing visibly broken HTTPS from day one?

reply


Is there reason to believe that the same key is used on all machines?

reply


Click the first Twitter link?

reply


>They install a web proxy which MITMs all web connections, including HTTPS by means of a pre-installed trusted root certificate.

That's the odd part of this. Browser plugins can modify the DOM (insert ads, change search results, etc) without proxying anything. So why do it? I wonder if they were fishing for an NSA contract to further monetize the installs.

reply


Jebus, how far the might IBM laptop line has fallen under the leadership of Lenovo. There was a time when a ThinkPad was arguably the best laptop money could buy. Many companies, including Google, would offer a choice between a ThinkPad or a MacBook, because those were the really reliable choices that were free of shovelware.

I even considered buying a Lenovo recently when a pretty nice looking ThinkPad was on sale, but a couple of friends have had very bad experiences with their Lenovo laptops. Both have had to go back to Lenovo for repairs; one of them had to send it back twice, and on the second go around demanded a new one instead of a repaired one, because the "repaired" one was worse than when it went in for repairs.

That said, there's "bad QC", which is forgivable with time and a sincere effort by the company to correct it, and then there's "evil". Intentionally shipping adware is evil.

Given this, I can genuinely think of no way for Lenovo to ever get my business for any product.

reply


Is it even possible to buy a Windows laptop right now with only the OS installed?

This is exactly why I've been recommending Chromebooks to anyone who asks my advice for about a year now.

reply


You can buy "Microsoft Signature" machines from the MS stores and online.

reply


Microsoft sell their own laptops, in US. They are said to be good.

reply


I think Microsoft sells those in its stores but even then I'm pretty sure they come with a few things but mostly from the manufacturer.

It would sure be nice to bring home a Windows machine that only had Windows on it and any necessary but minor applications from the manufacturer (like a settings application or drivers and not some photo sharing spyware).

reply


I've had great experiences with the ThinkPad T420, but after this news I'll likely never be buying a Lenovo product again. A damn shame.

reply


Ugh.

So for "developer-tier" laptops, i.e. not a netbook, does that pretty much leave Apple as the sole non-shit laptop maker? Is there a chromebook out there that runs linux pretty well if you pull chromeOS off?

You pay a hefty premium for that backlit Apple logo on the lid, and I'd prefer to get something a little more down-to-earth.

reply


I'm surprised that this is just now news. I received complaints from people participating in our beta trial (http://sketchtogether.com) from as early as October 22nd, 2014 that our website was broken, and it was because of Superfish being installed on their lenovo laptops. When they uninstalled Superfish, our webpage started working again.

Superfish injected a line of code that referenced "sf_main.jsp" from a remote site into all webpages (including ours) that interfered with our code. Here's a pastebin of the sf_main.jsp javascript file it linked to: http://pastebin.com/bZFkfRd5 (I assume the linked code is not copyrighted, if it is, please let me know and I can take it down).

reply


Line 194 -- They customized their ad script for Lenovo. Making them entirely aware of what's going on...

reply


An all-new reason to use Content-Security-Policy.

How much you want to bet that thing is XSSable?

reply


>An all-new reason to use Content-Security-Policy

Correct me if I'm wrong, but I don't think any amount of CSP will help you in this situation. They're MITMing traffic and thus can modify the CSP headers.

reply


Fair enough, though I'd bet they aren't smart enough to have actually blocked the header. They apparently don't even support WebSocket.

reply


Since this certificate is unconstrained it can probably be used to sign drivers...

reply


I don't see myself ever bothering to keep the default windows install on a thinkpad but this really hurts my impression of the company regardless. I've had my eye on the new X1s and had planned to upgrade my X201 this year but now I'm having second thoughts.

Who if anyone has taken over the place of great laptop for linux / development?

reply


I don't know about dev, but here are three linux computer/laptop companies in descending order of how nice their websites look:

https://system76.com/

https://zareason.com/shop/Laptops/

https://www.thinkpenguin.com/

reply


The new Dell XPS 13 looks like a very nice laptop. I have the previous version and it works very well with Linux.

reply


Can someone with one of these laptops connect to https://www.howsmyssl.com/ and post what it says? I'm curious what cipher suites are used from the proxy to the real site.

reply


not a laptop, a VM that I've built with a similar environment but:

http://i.imgur.com/YyawOxc.png http://i.imgur.com/V33bYuv.png

reply


Lenovo going down the drain. All they had to do was continue the Thinkpad legacy left by IBM. It's honestly breathtaking how badly they've fucked up. After the touch-based function keys, ruining the trackpoint buttons and now this. It's unbelievable.

reply


They brought the trackpoint buttons back on the latest line and you can switch the F-keys back to being the defaults via a bios setting. Just in case you were curious.

reply


And they never preinstalled this on ThinkPads as far as I know.

-----


Interesting that the Superfish job page is looking for an iOS kernel hacker. And by "interesting" I mean "horrifying".

reply


Well, it seems as though this [superfish] is categorized as a virus on most websites. From their own description:

"Superfish Window Shopper is a free browser add-on that instantly compares prices and shows similar items on ANY product in hundreds of U.S. online stores including Amazon.com, Best Buy, Macys, Nordstorm, Overstock.com, Staples, Target, and Wal-mart."

So if I have this right, this is essentially a massive affiliate scheme to produce revenue for the company? If it compares prices on all these sites, affid='s are injected for Lenovo and a % of the sale is given to them?

There reviews are horrible as well. All spam / annoyance related.

reply


About a week ago I was trying to troubleshoot Nitrous.io for a friend because she had complained that it wasn't establishing a connection. We discovered along the way that there was an odd line of Javascript on the page that immediately had me assume that her computer was infected with a virus.

A Google search on the filename had others saying that it was removable by uninstalling some Lenovo Utility preinstalled.

reply


Just found this: Spy agencies ban Lenovo PCs on security concerns (27th July 2013) - http://www.afr.com/p/technology/spy_agencies_ban_lenovo_pcs_...

"Multiple intelligence and defence sources in Britain and Australia confirmed there is a written ban on computers made by the Chinese company [Lenovo] being used in “classified” networks."

reply


IIRC, that article is a fine combination of bullshit and technically correct. There is a "written ban" purchasing equipment from anyone not on the approved vendor list. Lenovo didn't ask to be on the list, they're not on the list, therefore they're banned. As am I. As are you.

reply


I thought that had to do with the fact that they're a chinese owned company and if say the CIA makes a large order (or any order really) the chinese government might step in and force malware to be installed.

reply


Another black eye if they knew about Superfish and didn't alert their citizens.

reply


It is from 2013 though.

reply


This reinforces my policy of buying laptops with the cheapest drive offered and replacing the drive with an SSD before the first boot. I run Linux anyway, so booting Windows has no value for me.

reply


I recently did this exact thing -- bought a Lenovo laptop with a 5400 RPM disk drive, and immediately popped it out and replaced it with a Crucial MX100 SSD. Installed Linux, it works great :)

reply


You also have to reflash all firmware with known-trusted versions using a known-trusted reflasher to be safe.

... and replace the CPU with one that is known not to have backdoors. You'll have to craft it from Silicon yourself, though, because there aren't any available for sale anymore.

reply


This is what it looks like when people don't recognize that security is a spectrum.

reply


Can't you just write all 0's to the drive or just reformat it? Genuine question here, why would you need to physically replace the drive to ensure security when you can write to the whole thing?

reply


Would have to re-write/re-flash the firmware as well.

reply


What is it that the firmware can achieve? Is the firmware capable hijacking data, communicating with the NIC and transmitting data? Or is it somehow injecting harmful code? I feel like I'm missing something here.

reply


Ripped from yesterday's headlines ...

  ... rewrote the hard-drive firmware of infected computers—a
  never-before-seen engineering marvel that worked on 12 drive
  categories from manufacturers including Western Digital, Maxtor,
  Samsung, IBM, Micron, Toshiba, and Seagate.

  The malicious firmware created a secret storage vault that survived
  military-grade disk wiping and reformatting, making sensitive
  data stolen from victims available even after reformatting the
  drive and reinstalling the operating system. The firmware also
  provided programming interfaces that other code in Equation
  Group's sprawling malware library could access. Once a hard drive
  was compromised, the infection was impossible to detect or remove.
http://arstechnica.com/security/2015/02/how-omnipotent-hacke...

reply


That appears to be the act of a nation-state though. I don't really sweat those, because I'm pretty sure if the NSA really wants in to my machine, I can't stop them.

reply


Brilliant demonstration from a few years ago of what's possible with a hard drive firmware hack. You're basically completely fucked.

http://spritesmods.com/?art=hddhack&page=1

reply


Thanks, exactly the kind of information I was trying to elicit.

reply


Yes.

http://www.theregister.co.uk/2015/02/17/kaspersky_labs_equat...

reply


The drive firmware can change the bits going to/from the drive, no?

For example, it could binary-patch (either at write time or read time) your kernel image on disk to communicate with the NIC, etc...

reply


> with the cheapest drive offered and replacing the drive with an SSD

I expect the "cheapest drive" is not an SSD.

reply


hence "replacing the drive with an SSD"

reply


or a mac. Apple will do something like this when hell freezes over.

reply


According to various reports, this Superfish adware uses the same certificate across Lenovo computers. It should be easy to grab the private key out of the proxy binaries. And then... all these computers are vulnerable to arbitrary HTTPS man-in-the-middle attacks. Uh oh.

reply


You're assuming that the proxy is on the laptops, no?

reply


Well, the other possibility is that Superfish is routing and MITMing all traffic through its own servers, which is arguably worse.

reply


arguably? That's orders of magnitude worse

reply


Well, I dunno. In one case Superfish can see all your data and store it on their servers, in the other case _anyone on the internet_ can spoof any site (as soon as someone extracts the key). Either way is pretty bad.

But proxying all traffic from all Lenovo laptop owners through a third-party server without someone immediately noticing a problem is just not feasible, so I think we can assume that's not what they're doing.

reply


Are you sure? Android Chrome proxies all non-HTTPS traffic through a third-party server, by default. So it isn't like the traffic volume is impossible.

reply


It's not by default, you have to enable it.

https://support.google.com/chrome/answer/2392284

reply


Wow, really? I never knew that and some googling didn't find any decent sources. do you have one?

-----


Yes but that's Google. I'd be surprised if Superfish had resources like that, or could generate that much traffic from their servers and not be noticed (by, say, Google). I could be wrong.

reply


Lenovo was the last respected PC laptop brand. Is there anyone I can trust to sell me a well=made laptop anymore besides Apple?

reply


Clevo makes high quality laptops that are also very reasonably priced when bought barebones from the right vendor (they don't do direct consumer sales). Sager, System76, FalconNW, and a whole bunch of other boutique laptop companies are actually selling rebadged/modified Clevos.

reply


You can still wipe the hard drive and replace it with a Linux install (or a fresh Windows install, if you must).

reply


Asus is about it.

reply


I own two Asus products - Nexus 7 2012 and a K55VM series laptop. Both had problems with charging and used to get hot pretty soon.

reply


I thought so too, but my recent experience with a Zenbook has changed my view. WiFi drivers were so bad it took half a year after my purchase before the connection became stable (not dropping every 15 minutes requiring a reboot). Touchpad drivers were also a mess with awful kinetic scrolling. And just couple of weeks ago it stopped booting Windows altogehter (something related to ACPI I guess, Linux works if I don't use suspend). Conveniently one month after the expiration of the warranty.

reply


Despite the initial problems, I like my Zenbook.

The WiFi drivers are made by Intel, but yes, they were terrible (blue screen). I had to downgrade back to the drivers that came with Windows for while but the latest versions seem to be fine. I'm using some stock touchpad drivers that don't seem to have any kinetic scrolling.

But I'm the person who brought this to the attention of Hacker News: https://news.ycombinator.com/item?id=8546702

Basically after installing just about everything the laptop comes with, it seems to be running great. :)

reply


I'll just leave this out there : http://www.komodia.com/products/komodia-redirector/

reply


Download Valley, man.

reply


One more good reason to not buy a laptop with pre-installed OS.

reply


Was just about to purchase a lenovo... although I would have wiped it and installed linux immediately this has caused me to look elsewhere. when will companies learn this kind of behavior is toxic to their business?

reply


Unfortunately a very small proportion of potential customers are going to hear or care about this... it's about as toxic to their business as stepping in some stinging nettles is toxic to me.

reply


Unfortunately they have no competition in terms of a quality laptop to run Linux on. None of the competition offers similar features as my current x230 or the x250 I'm probably going to pick up later this year. If you could recommend a replacement that has a good keyboard, trackpoint, 12+ hours of real battery life, i7, etc. I'd be happy to hear about it.

reply


unfortunately you're completely correct.

reply


1. I connect to https://encrypted.google.com/ on Firefox and the certificate says it is verified by SuperFish.

2. Also, my broswer.newtab.url was changed to some URL (http://homepage-web.com/?s=lenovo&m=tab) instead of the default about:newtab

Steps to remove VisualDiscovery / Superfish

1. Home menu, search for Administrator tools 2. Open services 3. Find the VisualDiscovery service. Stop the service. Right click properties. Set "Startup type" to Disabled

4. Start -> Control panel 5. Add/ remove programs 6. Find Superfish and uninstall

reply


From what I understand, you need to go one further and spelunk through your local machine certificate stores and remove any Superfish certificates. They are not uninstalled.

reply


Given that antivirus products detect this as malware, does Lenovo not install any antivirus on their systems, or do they install a substandard one that fails to detect it?

reply


I wonder what are the legal repercussions of this, can't someone sue them?

reply


I think worse than that, I see criminal charges being brought up for this including fraud, theft, etc.

reply


The article says that Superfish "injects third-party ads on Google searches." Does that include https://encrypted.google.com/ in Chrome and Firefox, or do key pinning and HSTS preloading successfully prevent that?

EDIT: According to another comment here, HTTPS connections in Firefox aren't affected because they don't use the system certificate store. But what about Chrome - do users see an error on pages with pinned keys, or is the proxy smart enough not to attack those connections? Or does it also disable Chrome security features like HSTS and key pinning?

reply


Locally added CAs override pinning, so no it wont help.

reply


Just one more very good reason why the first thing I do with a new OEM machine of any kind is reformat and reinstall from my own media.

reply


Wow. I just bought my first Lenovo product recently, a Q190. I will not be purchasing anything from them again.

reply


Yeah this is really disappointing. Lenovo had become my 'goto' recommendation for people looking for a laptop.

Sure as hell not going to be doing that any more.

reply


Better yet, return it as defective.

reply


Hopefully Redmond will give hell to Lenovo for this.

Also, apparently this is just the start for crapware on new PCs - Paul Thurrott said on the podcast Windows Weekly about a week ago that crapware is going to get a lot worse this PC cycle.

reply


Oh, let us not forget the crap PC cleaner program that gets included in the Superfish install ("a Microsoft Partner"):

http://i.imgur.com/7cFlZLr.png

http://i.imgur.com/R4sHowP.png

So on a fresh Windows 7 virtual machine with zero apps installed, this program gives me 200 some errors and wants $49.99 (-$20 for instant savings) to register the program. This keeps getting better. Typical scam.

reply


As a Lenovo owner, I'm really pissed off, and offended. I feel violated. I just can't comprehend how they could think they wouldn't get caught at something like this. Especially with the current climate of the privacy movement in the US. This is bad, very bad for Lenovo.

reply


Stupid. I don't understand their motivations - are they making such a huge amount of money from this?

Lenovo doesn't stand out as much as they used to. Dell/HP/Apple make pretty great business laptops these days. If everything else is equal and I know the competitor (for example) won't install adware, then why would I ever buy Lenovo again?

reply


Proof that this has been happening since at least December 2014: http://itnerdysoldier.blogspot.cz/2014/12/where-does-this-ww...

reply


How to kill a brand in 1 easy step: do this.

reply


This is like the Avast spyware story: once you break trust, it's really difficult to get it back.

reply


I am guessing the Lenovo machines that are bought from the Microsoft Store are free of this, because of the Signature PC program, might be worth the extra cost if any and the trip there to get a crapware free machine.

reply


why risk it.

reply


Unbelievable. Guess switching to Apple from Lenovo last autumn wasn't the worst choice.

reply


First thing I also do on a new PC is reinstall the OS from scratch and get rid of all the preinstalled shit.

reply


Your strategy works only if you have a clean copy of the OS or you buy one (since the thread is about Lenovo I assume you are talking about Windows). Typically, a new PC doesn't come anymore with a copy of the OS, but with a hidden recovery partition that will basically let you do a factory reset (meaning all the crap will show up again).

reply


Microsoft itself has provided Windows installation media for download since Windows 8, including Windows 7 media. All you have to do is read your key off BIOS or the sticker.

And of course Windows 10 will be a free download.

reply


Free? I thought that was only if you already had 7 or 8 installed.

reply


Unless things have changed, usually the sticker key is only valid for a certain kind of media. E.g. VLK's only work with VLK images, retail keys only work with retail images...

reply


Would it be correct to assume that this doesn't affect any of the thinkpads used at IBM?

reply


Superfish. How apt.

reply


I presume the next step is Adware installation on in the flash of the system's boot drive.

reply


So, what you're saying is that people still use the hard drives that come with their laptops.

Interesting....

reply




Applications are open for YC Summer 2015


Guidelines | FAQ | Support | Lists | Bookmarklet | DMCA | Y Combinator | Apply | Contact

Search: